From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff McGee Subject: Re: [PATCH 10/15] acpi: Export acpi_bus_type Date: Tue, 30 Aug 2016 16:09:15 -0700 Message-ID: <20160830230915.GH2834@jeffdesk> References: <20160830164910.1248-1-jeff.mcgee@intel.com> <20160830164910.1248-11-jeff.mcgee@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:39691 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbcH3XCh (ORCPT ); Tue, 30 Aug 2016 19:02:37 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: isg-gms@eclists.intel.com, Ankitprasad Sharma , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List On Wed, Aug 31, 2016 at 12:47:39AM +0200, Rafael J. Wysocki wrote: > On Tue, Aug 30, 2016 at 6:49 PM, wrote: > > From: Ankitprasad Sharma > > > > Some modules, like i915.ko, needs to detect when certain ACPI features are > > active inorder to prevent corruption on contended resources. > > In particular, use of BIOS RapidStart Technology may corrupt the contents of > > the reserved graphics memory, due to unalarmed hibernation. In which case > > i915.ko cannot assume that it (reserved gfx memory) remains unmodified and > > must recreate the contents and importantly not use it to store unrecoverable > > user data. > > The above doesn't explain why you need to export acpi_bus_type at all. > > I suspect that this is in order to be able to do some hackish stuff on > it, so I'm not going to approve this patch as is. > My apologies. I was forwarding this collection internally with git send-mail but didn't scrub the original patch cc list. Please disregard. > > Signed-off-by: Ankitprasad Sharma > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Jeff McGee > > --- > > drivers/acpi/scan.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index 4b22ea8..7461bab 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -1269,6 +1269,7 @@ struct bus_type acpi_bus_type = { > > .remove = acpi_device_remove, > > .uevent = acpi_device_uevent, > > }; > > +EXPORT_SYMBOL_GPL(acpi_bus_type); > > > > static void acpi_device_del(struct acpi_device *device) > > { > > -- > > Thanks, > Rafael