From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [RFC PATCH V5 4/5] ARM64/PCI: Start using quirks handling for ACPI based PCI host controller Date: Sun, 4 Sep 2016 21:27:53 -0500 Message-ID: <20160905022753.GE30488@localhost> References: <1470661541-26270-1-git-send-email-tn@semihalf.com> <1470661541-26270-5-git-send-email-tn@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.136]:53262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754623AbcIEC2F (ORCPT ); Sun, 4 Sep 2016 22:28:05 -0400 Content-Disposition: inline In-Reply-To: <1470661541-26270-5-git-send-email-tn@semihalf.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tomasz Nowicki Cc: arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, Lorenzo.Pieralisi@arm.com, hanjun.guo@linaro.org, okaya@codeaurora.org, jchandra@broadcom.com, cov@codeaurora.org, dhdang@apm.com, ard.biesheuvel@linaro.org, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, jeremy.linton@arm.com, liudongdong3@huawei.com, gabriele.paoloni@huawei.com, jhugo@codeaurora.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 03:05:40PM +0200, Tomasz Nowicki wrote: > Since there are platforms which have non-compliant ECAM space we need to > override these accessors prior to PCI buses enumeration. In order to do > that we call pci_mcfg_match_quirks() to retrieve custom > pci_config_window structure. If no correlated quirk on list, use > fully ECAM compliant generic PCI config accessors. > > Signed-off-by: Tomasz Nowicki > --- > arch/arm64/kernel/pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 2e7bed4..aa734bd 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -139,8 +139,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) > if (!ri) > return NULL; > > - ri->cfg = pci_acpi_setup_ecam_mapping(root, > - &pci_generic_ecam_ops.pci_ops); > + ri->cfg = pci_mcfg_match_quirks(root); I don't really like this part: previously it was obvious that we're setting up ECAM mappings, and now it's not. I think the quirk functionality should be buried somewhere inside; it shouldn't be something this generic code has to worry about. > if (!ri->cfg) { > kfree(ri); > return NULL; > -- > 1.9.1 >