From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] watchdog: wdat_wdt: Ping the watchdog on resume Date: Fri, 21 Oct 2016 15:52:12 +0300 Message-ID: <20161021125212.GW24289@lahna.fi.intel.com> References: <20161020150336.97791-1-mika.westerberg@linux.intel.com> <20161020151738.GP24289@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:46240 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932869AbcJUM6v (ORCPT ); Fri, 21 Oct 2016 08:58:51 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: "linux-watchdog@vger.kernel.org" , Wim Van Sebroeck , Guenter Roeck , "Rafael J. Wysocki" , ACPI Devel Maling List On Thu, Oct 20, 2016 at 05:48:32PM +0200, Rafael J. Wysocki wrote: > On Thu, Oct 20, 2016 at 5:17 PM, Mika Westerberg > wrote: > > On Thu, Oct 20, 2016 at 05:05:22PM +0200, Rafael J. Wysocki wrote: > >> On Thu, Oct 20, 2016 at 5:03 PM, Mika Westerberg > >> wrote: > >> > It turns out we need to ping the watchdog hardware on resume when we > >> > re-program it. Otherwise this results inadvertent reset to trigger right > >> > after the resume is completed. > >> > > >> > Signed-off-by: Mika Westerberg > >> > >> Is there a Fixes: tag missing here? > > > > Oops, right. Sorry about that. > > > > It should be: > > > > Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog") > > > > (I can resend the patch as well, if needed with the Fixes tag). > > No worries, I can pick this up from here. Thanks :-)