* [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE
@ 2016-11-21 13:33 Mika Westerberg
2016-11-21 15:14 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2016-11-21 13:33 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Vegard Nossum, Wim Van Sebroeck, Guenter Roeck, Mika Westerberg,
linux-acpi, linux-kernel
The WDAT watchdog driver uses functionality provided by the watchdog timer
core but it did not select it explicitly. This results following linker
error when only WDAT_WDT is enabled in Kconfig:
drivers/built-in.o: In function `wdat_wdt_probe':
drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
enabled.
Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index fdd3228e0678..3eb58cb51e56 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -155,6 +155,7 @@ config TANGOX_WATCHDOG
config WDAT_WDT
tristate "ACPI Watchdog Action Table (WDAT)"
depends on ACPI
+ select WATCHDOG_CORE
select ACPI_WATCHDOG
help
This driver adds support for systems with ACPI Watchdog Action
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE
2016-11-21 13:33 [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE Mika Westerberg
@ 2016-11-21 15:14 ` Guenter Roeck
2016-11-24 1:30 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2016-11-21 15:14 UTC (permalink / raw)
To: Mika Westerberg, Rafael J. Wysocki
Cc: Vegard Nossum, Wim Van Sebroeck, linux-acpi, linux-kernel
On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> The WDAT watchdog driver uses functionality provided by the watchdog timer
> core but it did not select it explicitly. This results following linker
> error when only WDAT_WDT is enabled in Kconfig:
>
> drivers/built-in.o: In function `wdat_wdt_probe':
> drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
>
> Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> enabled.
>
> Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fdd3228e0678..3eb58cb51e56 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -155,6 +155,7 @@ config TANGOX_WATCHDOG
> config WDAT_WDT
> tristate "ACPI Watchdog Action Table (WDAT)"
> depends on ACPI
> + select WATCHDOG_CORE
> select ACPI_WATCHDOG
> help
> This driver adds support for systems with ACPI Watchdog Action
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE
2016-11-21 15:14 ` Guenter Roeck
@ 2016-11-24 1:30 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-11-24 1:30 UTC (permalink / raw)
To: Guenter Roeck, Mika Westerberg
Cc: Vegard Nossum, Wim Van Sebroeck, linux-acpi, linux-kernel
On Monday, November 21, 2016 07:14:08 AM Guenter Roeck wrote:
> On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> > The WDAT watchdog driver uses functionality provided by the watchdog timer
> > core but it did not select it explicitly. This results following linker
> > error when only WDAT_WDT is enabled in Kconfig:
> >
> > drivers/built-in.o: In function `wdat_wdt_probe':
> > drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
> >
> > Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> > enabled.
> >
> > Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> > Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-24 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 13:33 [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE Mika Westerberg
2016-11-21 15:14 ` Guenter Roeck
2016-11-24 1:30 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox