From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
tpmdd-devel@lists.sourceforge.net, nayna@linux.vnet.ibm.com,
linux-acpi@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] tpm: vtpm_proxy: Do not access host's event log
Date: Mon, 21 Nov 2016 11:32:34 -0700 [thread overview]
Message-ID: <20161121183234.GB9234@obsidianresearch.com> (raw)
In-Reply-To: <8e1bea0b-5409-5b69-7ac1-1e3e29cc3da7@linux.vnet.ibm.com>
On Fri, Nov 18, 2016 at 11:58:08AM -0500, Stefan Berger wrote:
> reason is just the acpi_os_map_iomem() call. Without calling the
> acpi_os_unmap_iomem() later on, which I assume should be allowed, the driver
> will crash when the device terminates.
The oops looks like unbalacned map/unmap, can you add some tracing
around the failing address and see if that is possibly true, and who
does it?
Jason
prev parent reply other threads:[~2016-11-21 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1479306245-14456-1-git-send-email-stefanb@linux.vnet.ibm.com>
[not found] ` <20161116153731.pmmnxiai7ouuj6qf@intel.com>
[not found] ` <3a38ddc6-1758-ae82-3df3-9cc55906880d@linux.vnet.ibm.com>
[not found] ` <65f392b6-5141-c726-dacb-a1649ea215de@linux.vnet.ibm.com>
[not found] ` <20161116200759.GA19593@obsidianresearch.com>
[not found] ` <ef1f954d-fc52-0522-01f7-b0e31ea14c59@linux.vnet.ibm.com>
2016-11-17 20:37 ` [PATCH] tpm: vtpm_proxy: Do not access host's event log Jarkko Sakkinen
2016-11-18 14:11 ` Stefan Berger
[not found] ` <abef96f0-97e3-22e6-c63b-4be5622b4fc2-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-18 14:15 ` Stefan Berger
[not found] ` <77bf7806-5007-feb4-e4a0-fc94775a5271-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-18 16:58 ` Stefan Berger
2016-11-21 18:32 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121183234.GB9234@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).