From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: vtpm_proxy: Do not access host's event log Date: Mon, 21 Nov 2016 11:32:34 -0700 Message-ID: <20161121183234.GB9234@obsidianresearch.com> References: <1479306245-14456-1-git-send-email-stefanb@linux.vnet.ibm.com> <20161116153731.pmmnxiai7ouuj6qf@intel.com> <3a38ddc6-1758-ae82-3df3-9cc55906880d@linux.vnet.ibm.com> <65f392b6-5141-c726-dacb-a1649ea215de@linux.vnet.ibm.com> <20161116200759.GA19593@obsidianresearch.com> <20161117203743.odzdpwwynzlqyt5m@intel.com> <77bf7806-5007-feb4-e4a0-fc94775a5271@linux.vnet.ibm.com> <8e1bea0b-5409-5b69-7ac1-1e3e29cc3da7@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from quartz.orcorp.ca ([184.70.90.242]:36368 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149AbcKUSci (ORCPT ); Mon, 21 Nov 2016 13:32:38 -0500 Content-Disposition: inline In-Reply-To: <8e1bea0b-5409-5b69-7ac1-1e3e29cc3da7@linux.vnet.ibm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Stefan Berger Cc: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, nayna@linux.vnet.ibm.com, linux-acpi@vger.kernel.org, linux-security-module@vger.kernel.org On Fri, Nov 18, 2016 at 11:58:08AM -0500, Stefan Berger wrote: > reason is just the acpi_os_map_iomem() call. Without calling the > acpi_os_unmap_iomem() later on, which I assume should be allowed, the driver > will crash when the device terminates. The oops looks like unbalacned map/unmap, can you add some tracing around the failing address and see if that is possibly true, and who does it? Jason