From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x Date: Wed, 30 Nov 2016 12:01:45 +0200 Message-ID: <20161130100145.GF1459@lahna.fi.intel.com> References: <1480475311-14385-1-git-send-email-tnhuynh@apm.com> <302ebc57-6f52-b0ff-e354-0c67556a88ed@samsung.com> <7efcf021-72c9-328a-ad88-4c226e8b5d6d@samsung.com> <10443ff4-67ff-d474-401f-21fa7f33a9a5@samsung.com> <328afec669295cbc3a4338a4347e7067@mail.gmail.com> <959f287f-74c1-d790-4f36-9c7ac053bc8e@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Peter Rosin , Phong Vo , "Rafael J. Wysocki" , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Loc Ho , Thang Nguyen , patches , Tin Huynh List-Id: linux-acpi@vger.kernel.org On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote: > It certainly downgrades code readability, but in case there is > similar surrounding code there are two options to keep the things > consistent - either stick to the current style or change it. > IMHO the latter would generate only unnecessary noise in this > particular case. Also that's the style we have been using when adding ACPI support to drivers.