Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

[Robert Richter <robert.richter@cavium.com>]

On 02.12.16 11:06:24, Tomasz Nowicki wrote:
> On 02.12.2016 07:42, Duc Dang wrote:

> >@@ -98,16 +98,16 @@ struct mcfg_fixup {
> >        { "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY,                 \
> >        &pci_thunder_ecam_ops }
> >        /* SoC pass1.x */
> >-   THUNDER_PEM_QUIRK(2,  0),       /* off-chip devices */
> >-   THUNDER_PEM_QUIRK(2,  1),       /* off-chip devices */
> >-   THUNDER_ECAM_QUIRK(2,  0),
> >-   THUNDER_ECAM_QUIRK(2,  1),
> >-   THUNDER_ECAM_QUIRK(2,  2),
> >-   THUNDER_ECAM_QUIRK(2,  3),
> >-   THUNDER_ECAM_QUIRK(2, 10),
> >-   THUNDER_ECAM_QUIRK(2, 11),
> >-   THUNDER_ECAM_QUIRK(2, 12),
> >-   THUNDER_ECAM_QUIRK(2, 13),
> >+ THUNDER_PEM_QUIRK(2, 0UL),  /* off-chip devices */
> >+ THUNDER_PEM_QUIRK(2, 1UL),  /* off-chip devices */
> >+ THUNDER_ECAM_QUIRK(2, 0UL),
> >+ THUNDER_ECAM_QUIRK(2, 1UL),
> >+ THUNDER_ECAM_QUIRK(2, 2UL),
> >+ THUNDER_ECAM_QUIRK(2, 3UL),
> >+ THUNDER_ECAM_QUIRK(2, 10UL),
> >+ THUNDER_ECAM_QUIRK(2, 11UL),
> >+ THUNDER_ECAM_QUIRK(2, 12UL),
> >+ THUNDER_ECAM_QUIRK(2, 13UL),
> >
> 
> The UL suffix is needed for *THUNDER_PEM_QUIRK* only. THUNDER_ECAM_QUIRK is
> fine.

We should better make the type cast part of the macro.

+ this:

---
#define THUNDER_MCFG_RES(addr, node) \
       DEFINE_RES_MEM(addr + (node << 44), 0x39 * SZ_16M)
---

The args in the macro need parentheses.

-Robert