From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jayachandran C <jchandra@broadcom.com>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-acpi@vger.kernel.org, Tomasz Nowicki <tn@semihalf.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [RFC PATCH v3 5/5] PCI: ACPI: Add a generic ACPI based host controller
Date: Fri, 18 Dec 2015 11:35:03 +0100 [thread overview]
Message-ID: <2016693.gtbtd8TMEz@wuerfel> (raw)
In-Reply-To: <1450269755-21420-6-git-send-email-jchandra@broadcom.com>
On Wednesday 16 December 2015 18:12:35 Jayachandran C wrote:
> Add a simple ACPI based PCI host controller. This is done by
> providing a simple implementation for pci_acpi_scan_root().
>
> The pci_mmcfg_list handling is done by the ACPI code, we
> keep a reference to the pci_mmcfg_region which is already
> mapped.
>
> This is enabled only for ARM64 now.
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> drivers/pci/host/Kconfig | 7 ++
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pci-host-acpi.c | 193 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 201 insertions(+)
> create mode 100644 drivers/pci/host/pci-host-acpi.c
(just noticed this got stuck in my outbox, sending it late)
I think this would be better put into drivers/acpi/pci_root.c, it directly
interacts with the code that is already there, and it's by no means
a standalone driver.
Also, there is no need for a Kconfig symbol that way.
You can put it into #if !(defined(CONFIG_X86) || defined(CONFIG_IA64))
if the code cannot be shared with the other architectures at the moment.
Arnd
prev parent reply other threads:[~2015-12-18 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 12:42 [RFC PATCH v3 0/5] Simple ACPI based PCI support for arm64 Jayachandran C
2015-12-16 12:42 ` [RFC PATCH v3 1/5] ACPI: MCFG: Move mmcfg_list management to drivers/acpi Jayachandran C
2015-12-16 12:42 ` [RFC PATCH v3 2/5] arm64: pci: Add ACPI support Jayachandran C
2015-12-16 14:24 ` Arnd Bergmann
2015-12-16 12:42 ` [RFC PATCH v3 3/5] PCI: Handle NULL parent in pci_bus_assign_domain_nr Jayachandran C
2015-12-16 12:42 ` [RFC PATCH v3 4/5] ACPI: PCI: Support platforms that need pci_remap_iospace Jayachandran C
2015-12-16 12:42 ` [RFC PATCH v3 5/5] PCI: ACPI: Add a generic ACPI based host controller Jayachandran C
2015-12-18 10:35 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2016693.gtbtd8TMEz@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jchandra@broadcom.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox