Re: [patch] ACPI/IORT: fix an error code

Hanjun Guo
2017-01-18T02:09:50Z

On 2017/1/17 21:36, Dan Carpenter wrote:
> We accidentally return success if platform_device_alloc() fails.
>
> Fixes: 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index e0d2e6e..655407a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
>
> pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
> if (!pdev)
> - return PTR_ERR(pdev);
> + return -ENOMEM;
>
> count = ops->iommu_count_resources(node);

Acked-by: Hanjun Guo <hanjun.guo@linaro.org>

Thanks
Hanjun