From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ACPI/IORT: fix an error code
Date: Tue, 17 Jan 2017 13:54:30 +0000 [thread overview]
Message-ID: <20170117135430.GA2393@red-moon> (raw)
In-Reply-To: <20170117121910.GA29263@mwanda>
On Tue, Jan 17, 2017 at 04:36:23PM +0300, Dan Carpenter wrote:
> We accidentally return success if platform_device_alloc() fails.
>
> Fixes: 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index e0d2e6e..655407a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> @@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
>
> pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
> if (!pdev)
> - return PTR_ERR(pdev);
> + return -ENOMEM;
>
> count = ops->iommu_count_resources(node);
>
next prev parent reply other threads:[~2017-01-17 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 13:36 [patch] ACPI/IORT: fix an error code Dan Carpenter
2017-01-17 13:54 ` Lorenzo Pieralisi [this message]
2017-01-18 2:09 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117135430.GA2393@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=hanjun.guo@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox