From: Hans de Goede <hdegoede@redhat.com>
To: Thierry Reding <thierry.reding@gmail.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Cc: linux-pwm@vger.kernel.org, linux-acpi@vger.kernel.org,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH v2 2/3] pwm/core: Try to get the module from pwm_get
Date: Sun, 22 Jan 2017 17:14:08 +0100 [thread overview]
Message-ID: <20170122161409.21601-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20170122161409.21601-1-hdegoede@redhat.com>
Add a module_name string to the pwm_lookup struct and if specified
and pwmchip_find_by_name() does not find the pwmchip try calling
request_module with the specified name.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/pwm/core.c | 4 ++++
include/linux/pwm.h | 11 +++++++++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 0d3ef29..c418a7a 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -823,6 +823,10 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id)
return ERR_PTR(-ENODEV);
chip = pwmchip_find_by_name(chosen->provider);
+ if (!chip && chosen->module_name) {
+ request_module(chosen->module_name);
+ chip = pwmchip_find_by_name(chosen->provider);
+ }
if (!chip)
return ERR_PTR(-EPROBE_DEFER);
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 2c6c511..40ab8b6 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -613,18 +613,25 @@ struct pwm_lookup {
const char *con_id;
unsigned int period;
enum pwm_polarity polarity;
+ const char *module_name; /* Optional may be NULL */
};
-#define PWM_LOOKUP(_provider, _index, _dev_id, _con_id, _period, _polarity) \
+#define PWM_LOOKUP_MODNAME(_provider, _index, _dev_id, _con_id, _period, \
+ _polarity, _module_name) \
{ \
.provider = _provider, \
.index = _index, \
.dev_id = _dev_id, \
.con_id = _con_id, \
.period = _period, \
- .polarity = _polarity \
+ .polarity = _polarity, \
+ .module_name = _module_name \
}
+#define PWM_LOOKUP(_provider, _index, _dev_id, _con_id, _period, _polarity) \
+ PWM_LOOKUP_MODNAME(_provider, _index, _dev_id, _con_id, _period, \
+ _polarity, NULL)
+
#if IS_ENABLED(CONFIG_PWM)
void pwm_add_table(struct pwm_lookup *table, size_t num);
void pwm_remove_table(struct pwm_lookup *table, size_t num);
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-22 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 16:14 [PATCH v2 0/3] acpi_lpss/pwm: Fix i915 pwm_get issues Hans de Goede
2017-01-22 16:14 ` [PATCH v2 1/3] pwm/core: Don't hold pwm_lookup_lock longer then necessary Hans de Goede
2017-01-22 16:14 ` Hans de Goede [this message]
2017-01-30 8:17 ` [PATCH v2 2/3] pwm/core: Try to get the module from pwm_get Thierry Reding
2017-01-30 14:18 ` Hans de Goede
2017-01-22 16:14 ` [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device Hans de Goede
2017-01-30 8:18 ` Thierry Reding
2017-01-30 8:28 ` Rafael J. Wysocki
2017-01-30 9:33 ` Mika Westerberg
2017-01-30 9:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122161409.21601-3-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox