From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v20 08/17] clocksource/drivers/arm_arch_timer: Rework counter frequency detection. Date: Tue, 31 Jan 2017 11:42:33 +0000 Message-ID: <20170131114233.GB11191@leverpostej> References: <20170118132541.8989-1-fu.wei@linaro.org> <20170118132541.8989-9-fu.wei@linaro.org> <20170124172400.GG7572@leverpostej> <20170125172505.GB29027@leverpostej> <20170130174958.GA3496@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170130174958.GA3496@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fu Wei Cc: Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , Linux Kernel Mailing List , Julien Grall , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Sudeep Holla , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists. List-Id: linux-acpi@vger.kernel.org On Mon, Jan 30, 2017 at 05:49:59PM +0000, Mark Rutland wrote: > On Thu, Jan 26, 2017 at 01:49:03PM +0800, Fu Wei wrote: > > And because Linux kernel is running on Non-secure EL1, so should we > > skip "SECURE" timer in Linux? > > I guess you mean by checking the GTx Common flags, to see if the timer > is secure? Yes, we must skip those. > > Looking further at this, the ACPI spec is sorely lacking any statement > as to the configuration of CNTCTLBase.{CNTSAR,CNTTIDR,CNTACR}, so it's > not clear if we can access anything in a frame, even if it is listed as > being a non-secure timer. Given CNTNSAR.NS enables non-secure access to CNTACR, I guess the obvious interpretation is that for frames listed as non-secure, this has been configured to permit non-secure access to the frame and associated CNTACR. I will work to that assumption while reviewing, though I still believe this needs to be clarified in the spec. Thanks, Mark.