Re: [PATCH v3 0/4] Export APIs to copy device properties & more

Dmitry Torokhov
2017-02-01T22:56:12Z

On Wed, Feb 01, 2017 at 09:31:21AM -0800, Dmitry Torokhov wrote:
> Hi,
>
> Here is the refreshed series exporting APIs to copy statically declared
> device properties. The reason is that we want to augment ACPI-based devices
> with properties, and drivers usually have a largish DMI table for multiple
> models, so it is desirable to mark everything as __initdata/__initconst,
> and then copy only the entry matching the device we are running on and
> discard the rest.
>
> The last patch is not really about device property APIs, but rather
> allowing users to attach properties to i2c_board_info, and have them
> attached to instantiated device(s). The reason it is included is because it
> depends on device_add_properties() taking const pointer, which is patch #2.
>
> If it seems useful I hope Rafael and Wolfram would figure a way to merge it
> :).

By the way, if this series is accepted, it would be very helpful to have
it in a stable branch off 4.10-rcX as I have more patches to
platform/chrome and Atmel touchscreen driver depending on it.

>
> v3:
> - fix memory leak in property_copy_string_array() pointed out by Mika
> Westerberg
>
> v2:
> - addressed Andy's comments
> - added property_entries_free()
> - added patch to allow constify values of property arrays
> - added i2c patch allowing to attach property to devices via board info
>
> v1:
> - initial posting
>
>
> Dmitry Torokhov (4):
> device property: export code duplicating array of property entries
> device property: allow to constify properties
> driver property: constify property arrays values
> i2c: allow specify device properties in i2c_board_info
>
> drivers/base/property.c | 222 ++++++++++++++++++++++++++++++-----------------
> drivers/i2c/i2c-core.c | 16 +++-
> include/linux/i2c.h | 3 +
> include/linux/property.h | 19 ++--
> 4 files changed, 171 insertions(+), 89 deletions(-)
>
> Thanks.
>
> --
> Dmitry
>

--
Dmitry