From: Joerg Roedel <joro@8bytes.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Joerg Roedel <jroedel@suse.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ACPI: Don't create a platform_device for IOAPIC/IOxAPIC
Date: Thu, 23 Mar 2017 00:58:05 +0100 [thread overview]
Message-ID: <20170322235805.GH7266@8bytes.org> (raw)
In-Reply-To: <CAJZ5v0iLDUUtGQeBRGTrz75o71S8uYAtjVP7p4H97e7-dRZhgA@mail.gmail.com>
On Thu, Mar 23, 2017 at 12:44:18AM +0100, Rafael J. Wysocki wrote:
> On Thu, Mar 23, 2017 at 12:41 AM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > It is not dead.
> >
> > Platform devices are actually created by it, but they never go away.
>
> IOW, they should never be created for anything hot-removable.
>
> If they are, this is a bug (as you noticed).
Okay, in this case patch 2 can be omitted.
But for my understanding, platform_devices created in acpi_bus_attach()
that are not hot-removable don't take a reference to the host_bridge,
right (at least when the host-bridge is hot-removable)?
Otherwise this would be a leak again in case the host-bridge gets
removed.
Joerg
next prev parent reply other threads:[~2017-03-22 23:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 17:33 [PATCH 0/3] ACPI Fixes for Hotplug Joerg Roedel
2017-03-22 17:33 ` [PATCH 1/3] ACPI, ioapic: Clear on-stack resource before using it Joerg Roedel
2017-03-22 17:33 ` [PATCH 2/3] ACPI: Remove platform devices from a bus on removal Joerg Roedel
2017-04-19 6:50 ` joeyli
2017-04-19 6:54 ` joeyli
2017-03-22 17:33 ` [PATCH 3/3] ACPI: Don't create a platform_device for IOAPIC/IOxAPIC Joerg Roedel
2017-03-22 17:42 ` Rafael J. Wysocki
2017-03-22 22:58 ` Joerg Roedel
2017-03-22 23:41 ` Rafael J. Wysocki
2017-03-22 23:44 ` Rafael J. Wysocki
2017-03-22 23:58 ` Joerg Roedel [this message]
2017-03-23 1:06 ` Rafael J. Wysocki
2017-03-23 10:50 ` Joerg Roedel
2017-03-23 11:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322235805.GH7266@8bytes.org \
--to=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).