From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74 Date: Mon, 8 May 2017 12:04:43 +0200 Message-ID: <20170508100443.GG16981@rric.localdomain> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> <1493986091-30521-2-git-send-email-gakula@caviumnetworks.com> <20170505230328.GN4906@rric.localdomain> <20170508091739.GA26003@virtx40> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: Robert Richter , Geetha Sowjanya , geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Geetha sowjanya , will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Linu Cherian , sgoutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Charles.Garcia-Tobin-5wv7dgnIgG8@public.gmane.org List-Id: linux-acpi@vger.kernel.org On 08.05.17 10:59:46, Robin Murphy wrote: > On 08/05/17 10:17, Linu Cherian wrote: > > This actually results in more lines of changes. If you think the below > > approach is still better, will post a V4 of this series with this change. > > Why not just do this?: > > static inline unsigned long page1_offset_adjust( > unsigned long off, struct arm_smmu_device *smmu) > { > if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu)) > return (off - SZ_64K); > > return off; > } > > AFAICS that should be the least disruptive way to go about it. Yeah, let's go with this. Thanks Robin, -Robert