From: Borislav Petkov <bp@suse.de>
To: Tyler Baicar <tbaicar@codeaurora.org>
Cc: rjw@rjwysocki.net, lenb@kernel.org, prarit@redhat.com,
bhelgaas@google.com, punit.agrawal@arm.com, mingo@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
shiju.jose@huawei.com, James.Morse@arm.com, ahs3@redhat.com
Subject: Re: [PATCH V3] acpi: apei: check for pending errors when probing GHES entries
Date: Sun, 21 May 2017 15:39:10 +0200 [thread overview]
Message-ID: <20170521133910.GA5676@nazgul.tnic> (raw)
In-Reply-To: <1495142562-7318-1-git-send-email-tbaicar@codeaurora.org>
On Thu, May 18, 2017 at 03:22:42PM -0600, Tyler Baicar wrote:
> Check for pending errors when probing GHES entries. It is possible
> that a fatal error is already pending at this point, so we should
> handle it as soon as the driver is probed. This also avoids a
> potential issue if there was an interrupt that was already
> cleared for an error since the GHES driver wasn't present.
>
> V3: Check for pending errors of all GHES types
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> ---
> drivers/acpi/apei/ghes.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d0855c0..5347230 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1039,6 +1039,9 @@ static int ghes_probe(struct platform_device *ghes_dev)
> }
> platform_set_drvdata(ghes_dev, ghes);
>
> + /* Handle any pending errors right away */
> + ghes_proc(ghes);
> +
> return 0;
> err_edac_unreg:
> ghes_edac_unregister(ghes);
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
prev parent reply other threads:[~2017-05-21 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 21:22 [PATCH V3] acpi: apei: check for pending errors when probing GHES entries Tyler Baicar
2017-05-21 13:39 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521133910.GA5676@nazgul.tnic \
--to=bp@suse.de \
--cc=James.Morse@arm.com \
--cc=ahs3@redhat.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).