From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH] acpi/iort, numa: Add numa node mapping for smmuv3 devices Date: Thu, 1 Jun 2017 17:21:42 +0100 Message-ID: <20170601162142.GC19003@red-moon> References: <1496325937-21113-1-git-send-email-ganapatrao.kulkarni@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1496325937-21113-1-git-send-email-ganapatrao.kulkarni-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Ganapatrao Kulkarni Cc: rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, Will.Deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jnair-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Thu, Jun 01, 2017 at 07:35:37PM +0530, Ganapatrao Kulkarni wrote: > ARM IORT specification has provision to define Proximity domain > in SMMUv3 IORT table. Adding required code to parse Proximity domain of > SMMUv3 IORT table. Parsed Proximity domain is used to set numa_node > of SMMUv3 platform devices. > > Signed-off-by: Ganapatrao Kulkarni > --- > drivers/iommu/arm-smmu-v3.c | 6 ++++++ > include/acpi/actbl2.h | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 69d8506..98c2319 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2667,6 +2667,12 @@ static int arm_smmu_device_acpi_probe(struct platform_device *pdev, > if (iort_smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE) > smmu->features |= ARM_SMMU_FEAT_COHERENCY; > > + /* set numa proximity domain for smmv3 device */ > + if (iort_smmu->flags & ACPI_IORT_SMMU_V3_PXM) { > + set_dev_node(dev, acpi_map_pxm_to_node(iort_smmu->pxm)); > + dev_info(dev, "on NUMA node %d\n", dev_to_node(dev)); It should be done in acpi/arm64/iort.c at device creation time. Thanks, Lorenzo > + } > + > return 0; > } > #else > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h > index 4b306a6..c16ced8 100644 > --- a/include/acpi/actbl2.h > +++ b/include/acpi/actbl2.h > @@ -805,6 +805,9 @@ struct acpi_iort_smmu_v3 { > u32 pri_gsiv; > u32 gerr_gsiv; > u32 sync_gsiv; > + u8 pxm; > + u8 reserved1; > + u16 reserved2; > }; > > /* Values for Model field above */ > @@ -817,6 +820,7 @@ struct acpi_iort_smmu_v3 { > > #define ACPI_IORT_SMMU_V3_COHACC_OVERRIDE (1) > #define ACPI_IORT_SMMU_V3_HTTU_OVERRIDE (1<<1) > +#define ACPI_IORT_SMMU_V3_PXM (1<<3) > > /******************************************************************************* > * > -- > 1.8.1.4 >