From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lee, Chun-Yi" Subject: [PATCH] acpi: handle the acpi hotplug schedule error Date: Wed, 7 Jun 2017 14:05:27 +0800 Message-ID: <20170607060527.23407-1-jlee@suse.com> Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:35983 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdFGGFk (ORCPT ); Wed, 7 Jun 2017 02:05:40 -0400 Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J . Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" , Len Brown Kernel should decrements the reference count of acpi device when scheduling acpi hotplug work is failed, and also evaluates _OST to notify BIOS the failure. Cc: "Rafael J. Wysocki" Cc: Len Brown Signed-off-by: "Lee, Chun-Yi" --- drivers/acpi/bus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 34fbe02..2f2cec9 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -427,8 +427,14 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS)) driver->ops.notify(adev, type); - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) - return; + if (hotplug_event) { + if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) { + acpi_bus_put_acpi_device(adev); + goto err; + } else { + return; + } + } acpi_bus_put_acpi_device(adev); return; -- 2.10.2