linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2] ACPI / scan: Fix enumeration for special SPI and I2C devices
Date: Mon, 19 Jun 2017 23:12:24 +0300	[thread overview]
Message-ID: <20170619201224.GP629@lahna.fi.intel.com> (raw)
In-Reply-To: <20170619125301.7016-1-jarkko.nikula@linux.intel.com>

On Mon, Jun 19, 2017 at 03:53:01PM +0300, Jarkko Nikula wrote:
> Commit f406270bf73d ("ACPI / scan: Set the visited flag for all
> enumerated devices") caused that two group of special SPI or I2C
> devices do not enumerate. SPI and I2C devices are expected to be
> enumerated by the SPI and I2C subsystems but change caused that
> acpi_bus_attach() marks those devices with acpi_device_set_enumerated().
> 
> First group of devices are matched using Device Tree compatible property
> with special _HID "PRP0001". Those devices have matched scan handler,
> acpi_scan_attach_handler() retuns 1 and acpi_bus_attach() marks them
> with acpi_device_set_enumerated().
> 
> Second group of devices without valid _HID such as "LNXVIDEO" have
> device->pnp.type.platform_id set to zero and change again marks them
> with acpi_device_set_enumerated().
> 
> Fix this by flagging the SPI and I2C devices during struct acpi_device
> object initialization time and let the code in acpi_bus_attach() to go
> through the device_attach() and acpi_default_enumeration() path for all
> SPI and I2C devices.
> 
> Fixes: f406270bf73d ("ACPI / scan: Set the visited flag for all enumerated devices")
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

      reply	other threads:[~2017-06-19 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 12:53 [PATCH v2] ACPI / scan: Fix enumeration for special SPI and I2C devices Jarkko Nikula
2017-06-19 20:12 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619201224.GP629@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).