From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Loc Ho <lho@apm.com>,
Aleksey Makarov <aleksey.makarov@linaro.org>,
Jon Mason <jon.mason@broadcom.com>, Jon Masters <jcm@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>, Lv <lv.zheng@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
patches@apm.com
Subject: Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage
Date: Tue, 4 Jul 2017 09:22:51 +0200 [thread overview]
Message-ID: <20170704072251.GA17867@kroah.com> (raw)
In-Reply-To: <CAJZ5v0gw82WcRomx0b=ZmxdXG4VFP8iCXSoQ_BvArQvOoi90TA@mail.gmail.com>
On Mon, Jul 03, 2017 at 11:44:30PM +0200, Rafael J. Wysocki wrote:
> On Mon, Jul 3, 2017 at 11:33 PM, Loc Ho <lho@apm.com> wrote:
> > The current SPCR code does not check the access width of the mmio, and
> > uses a default of 8bit register accesses. This prevents devices that
> > only do 16 or 32bit register accesses from working. By simply checking
> > this field and setting the mmio string appropriately, this issue can be
> > corrected. To prevent any legacy issues, the code will default to 8bit
> > accesses if the value is anything but 16 or 32.
> >
> > Signed-off-by: Loc Ho <lho@apm.com>
> > [Re-send as single patch set]
> > Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>
> Greg, Aleksey, any objections here?
>
> If not, I'll route this through the ACPI tree.
No objections from me for either of these patches:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-07-04 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 21:33 [PATCH v2 0/2] ACPI: SPCR: Use access width to determine mmio usage Loc Ho
2017-07-03 21:33 ` [PATCH v2 1/2] " Loc Ho
2017-07-03 21:44 ` Rafael J. Wysocki
2017-07-04 7:22 ` Greg Kroah-Hartman [this message]
2017-07-03 21:33 ` [PATCH v2 2/2] ACPI: SPCR: Workaround for APM X-Gene 8250 UART 32-alignment errata Loc Ho
2017-07-03 21:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704072251.GA17867@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aleksey.makarov@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@acpica.org \
--cc=jcm@redhat.com \
--cc=jon.mason@broadcom.com \
--cc=lenb@kernel.org \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=patches@apm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).