From: Borislav Petkov <bp@suse.de>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com,
sudeep.holla@arm.com, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot
Date: Thu, 20 Jul 2017 15:54:46 +0200 [thread overview]
Message-ID: <20170720135446.GA20641@nazgul.tnic> (raw)
In-Reply-To: <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com>
On Thu, Jul 20, 2017 at 01:29:17PM +0100, Punit Agrawal wrote:
> I agree that where there is a genuine problem, relevant messages can
> help to diagnose the problem. But what's printed now doesn't fit the
> criteria.
So make it fit the criteria. Change the code to not issue that message
when the platform doesn't have those tables. But keep it in the
remaining cases, when the tables are there.
You can't be removing useful error messages just because your platform
doesn't have the tables.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-07-20 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 11:03 [PATCH 0/4] Drop uninformative messages from bootlog Punit Agrawal
2017-07-20 11:04 ` [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal
2017-07-20 11:17 ` Borislav Petkov
2017-07-20 12:29 ` Punit Agrawal
2017-07-20 13:54 ` Borislav Petkov [this message]
2017-07-20 17:50 ` Punit Agrawal
2017-07-21 13:27 ` Borislav Petkov
2017-07-27 9:35 ` Punit Agrawal
2017-07-27 9:52 ` Borislav Petkov
2017-07-27 9:55 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720135446.GA20641@nazgul.tnic \
--to=bp@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox