From: Punit Agrawal <punit.agrawal@arm.com>
To: linux-acpi@vger.kernel.org
Cc: Punit Agrawal <punit.agrawal@arm.com>,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: [PATCH 3/3] ACPI / APEI: HEST: Don't set hest_disable if table not found
Date: Tue, 1 Aug 2017 14:36:08 +0100 [thread overview]
Message-ID: <20170801133608.21017-4-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170801133608.21017-1-punit.agrawal@arm.com>
During initialisation, the driver sets hest_disable to 1 if the HEST
table is not found. This value is checked during the GHES driver
initialisation and in turn leads to a message such as -
[ 3.460067] GHES: HEST is not enabled!
being output in the bootlog. The message appears even on systems that do
not have the HEST table or APEI support.
Update the initialisation to skip setting hest_disable when the HEST
table is not found.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Borislav Petkov <bp@suse.de>
---
drivers/acpi/apei/hest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 456b488eb1df..3aa1b34459b6 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -233,7 +233,7 @@ void __init acpi_hest_init(void)
status = acpi_get_table(ACPI_SIG_HEST, 0,
(struct acpi_table_header **)&hest_tab);
if (status == AE_NOT_FOUND)
- goto err;
+ return;
else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
pr_err(HEST_PFX "Failed to get table, %s\n", msg);
--
2.11.0
next prev parent reply other threads:[~2017-08-01 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 13:36 [PATCH 0/3] Refactor GHES to better support non-APEI systems Punit Agrawal
2017-08-01 13:36 ` [PATCH 1/3] GHES: Expand the estatus pool in ghes_estatus_pool_init() Punit Agrawal
2017-08-01 13:36 ` [PATCH 2/3] GHES: Move memory initialisation to ghes_probe() Punit Agrawal
2017-08-01 14:04 ` Punit Agrawal
2017-08-14 19:22 ` Borislav Petkov
2017-08-15 10:10 ` Punit Agrawal
2017-08-15 8:35 ` Borislav Petkov
2017-08-15 10:31 ` Punit Agrawal
2017-08-15 10:56 ` Borislav Petkov
2017-08-01 13:36 ` Punit Agrawal [this message]
2017-08-09 9:24 ` [PATCH 0/3] Refactor GHES to better support non-APEI systems Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801133608.21017-4-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=bp@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox