From: Will Deacon <will.deacon@arm.com>
To: Tyler Baicar <tbaicar@codeaurora.org>
Cc: rjw@rjwysocki.net, lenb@kernel.org, james.morse@arm.com,
bp@suse.de, shiju.jose@huawei.com, geliangtang@gmail.com,
andriy.shevchenko@linux.intel.com, tony.luck@intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
austinwc@codeaurora.org
Subject: Re: [PATCH] acpi: apei: fix GHES estatus iteration
Date: Tue, 8 Aug 2017 17:32:20 +0100 [thread overview]
Message-ID: <20170808163219.GB2163@arm.com> (raw)
In-Reply-To: <1501795945-5331-1-git-send-email-tbaicar@codeaurora.org>
On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote:
> Currently iterating through the GHES estatus blocks does not
> take into account the new generic data v3 structure size. This
> can result in garbage non-standard trace events to be triggered
> since the loop will not properly iterate through the estatus
> blocks and not properly terminate.
>
> Update the GHES estatus iteration to properly increment through
> the estatus blocks similar to how the CPER estatus printing
> iterates through them.
>
> Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure")
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> Tested-by: Austin Christ <austinwc@codeaurora.org>
> ---
> drivers/acpi/apei/apei-internal.h | 5 -----
> drivers/acpi/apei/ghes.c | 8 +++++++-
> 2 files changed, 7 insertions(+), 6 deletions(-)
Whilst much of the initial code here went through the arm64 tree in the
previous merge window, I'm assuming that Boris will take this fix via his
tree (likewise for "[PATCH V2] acpi: apei: clear error status before
acknowledging the error").
Will
next prev parent reply other threads:[~2017-08-08 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 21:32 [PATCH] acpi: apei: fix GHES estatus iteration Tyler Baicar
2017-08-08 16:32 ` Will Deacon [this message]
2017-08-09 0:52 ` Rafael J. Wysocki
2017-08-09 4:57 ` Borislav Petkov
2017-08-10 22:04 ` gengdongjiu
2017-08-11 13:17 ` Baicar, Tyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808163219.GB2163@arm.com \
--to=will.deacon@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=austinwc@codeaurora.org \
--cc=bp@suse.de \
--cc=geliangtang@gmail.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox