public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Ronald Tschalär" <ronald@innovation.ch>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Federico Lorenzi <florenzi@gmail.com>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] ACPI / LPSS: Don't abort acpi scan on missing mem resource.
Date: Wed, 9 Aug 2017 12:28:15 +0300	[thread overview]
Message-ID: <20170809092815.GR2369@lahna.fi.intel.com> (raw)
In-Reply-To: <1502266542-19268-1-git-send-email-ronald@innovation.ch>

On Wed, Aug 09, 2017 at 01:15:42AM -0700, Ronald Tschalär wrote:
> The keyboard and touchpad on MacBook's from 2015 onwards are connected
> via an SPI bus. On MacBook8's (2015) the ACPI device for the SPI master
> for this bus has _CID "INT33C1", and hence the acpi-lpss handler here is
> triggered for it. However, the DSDT lists no memory resources for this
> device, resulting in an error being returned by the attach callback and
> therefore the SPI master device being ignored. This prevents us from
> being able to register the keyboard and touchpad driver.
> 
> Furthermore, the controller (a Wildcat Point-LP controller) does not
> appear to need the functionality provided by the apci-lpss handler.
> Therefore we now just skip the handler if no memory resources are found
> and let the ACPI scan complete successfully for this device.
> 
> All of this is not an issue on later MacBook(Pro)'s because their ACPI
> SPI devices don't have any _CID and therefore no attempt is made to attach
> this handler.
> 
> Returning an error was introduced in commit d3e13ff3c1aa - this restores
> the original behaviour.
> 
> Link: https://github.com/cb22/macbook12-spi-driver
> Signed-off-by: Ronald Tschalär <ronald@innovation.ch>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2017-08-09  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  8:15 [PATCH v2] ACPI / LPSS: Don't abort acpi scan on missing mem resource Ronald Tschalär
2017-08-09  9:28 ` Mika Westerberg [this message]
2017-08-10 23:09   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809092815.GR2369@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=florenzi@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=ronald@innovation.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox