public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Lv Zheng <lv.zheng@intel.com>, Bob Moore <robert.moore@intel.com>
Subject: Re: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace
Date: Thu, 10 Aug 2017 11:23:38 +0300	[thread overview]
Message-ID: <20170810082338.GL2369@lahna.fi.intel.com> (raw)
In-Reply-To: <20170810051016.GA7953@wunner.de>

On Thu, Aug 10, 2017 at 07:10:16AM +0200, Lukas Wunner wrote:
> On Thu, Aug 10, 2017 at 12:34:23AM +0200, Rafael J. Wysocki wrote:
> > --- linux-pm.orig/drivers/acpi/scan.c
> > +++ linux-pm/drivers/acpi/scan.c
> > @@ -2139,6 +2139,10 @@ int __init acpi_scan_init(void)
> >  			acpi_get_spcr_uart_addr();
> >  	}
> >  
> > +	acpi_gpe_apply_masked_gpes();
> > +	acpi_update_all_gpes();
> > +	acpi_ec_ecdt_start();
> > +
> >  	mutex_lock(&acpi_scan_lock);
> >  	/*
> >  	 * Enumerate devices in the ACPI namespace.
> 
> I notice this is called from a subsys_initcall().  We scan the PCI bus
> much earlier in arch/x86/kernel/early-quirks.c and it would be possible
> to identify presence of Thunderbolt host controllers in an early quirk
> (using the method of pci_is_thunderbolt_attached()) and, if found,
> enable their GPEs or all GPEs.

I don't think we want to differentiate between Thunderbolt controller
and anything else. Point here is that we need to enable GPEs in the same
order than Windows does (before PCI scan) to be on the path that is at
least somehow tested.

> Just as an aside in case your method doesn't work, I'm not affected by
> this issue being a Mac user... ;-)

;-)

  parent reply	other threads:[~2017-08-10  8:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 22:29 [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan Rafael J. Wysocki
2017-08-09 22:30 ` [PATCH 1/3] ACPICA: Dispatch active GPEs at init time Rafael J. Wysocki
2017-08-10  1:48   ` Zheng, Lv
2017-08-10 16:06     ` Rafael J. Wysocki
2017-08-11  5:40       ` Zheng, Lv
2017-08-11 12:23         ` Rafael J. Wysocki
2017-08-15  9:59           ` Zheng, Lv
2017-08-15 12:21             ` Rafael J. Wysocki
2017-08-17  2:24               ` Zheng, Lv
2017-08-09 22:31 ` [PATCH 2/3] ACPICA: Make it possible to enable runtime GPEs earlier Rafael J. Wysocki
2017-08-10  1:52   ` Zheng, Lv
2017-08-10 16:07     ` Rafael J. Wysocki
2017-08-11  6:13       ` Zheng, Lv
2017-08-09 22:34 ` [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace Rafael J. Wysocki
2017-08-10  1:54   ` Zheng, Lv
2017-08-10  5:10   ` Lukas Wunner
2017-08-10  7:45     ` Zheng, Lv
2017-08-10  8:23     ` Mika Westerberg [this message]
2017-08-15  2:12   ` Zheng, Lv
2017-08-15 12:22     ` Rafael J. Wysocki
2017-08-17  2:25       ` Zheng, Lv
2017-08-10  9:34 ` [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810082338.GL2369@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=lv.zheng@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox