public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Lv Zheng <lv.zheng@intel.com>, Bob Moore <robert.moore@intel.com>
Subject: Re: [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan
Date: Thu, 10 Aug 2017 12:34:41 +0300	[thread overview]
Message-ID: <20170810093441.GQ2369@lahna.fi.intel.com> (raw)
In-Reply-To: <12346760.yAFCnkEgf6@aspire.rjw.lan>

On Thu, Aug 10, 2017 at 12:29:12AM +0200, Rafael J. Wysocki wrote:
> Hi,
> 
> This is exceptional for at least two reasons.
> 
> First, we need it now to work around boot problems on multiple platforms
> already seen in the field (which are shipping products).
> 
> Second, the ACPICA changes in this series are kind of Linux-specific, because
> they are related to how Linux carries out the initialization of devices, which
> very well may be different from what the other OSes using ACPICA do.
> 
> For these reasons, I'd like to make the following ACPICA changes in Linux
> only for the time being and then decide whether or not to take them into
> the upstream.  If there are major concerns about that, please let me know.
> 
> The issue at hand is that some platforms with Thunderbolt controllers won't
> boot if there are any Thunderbolt devices connected to them at boot time (if
> the devices are connected later, everything works as expected).  That turns
> out to be related to a complicated sequence of events involving the platform
> firmware which needs to happen in exactly the right order at the right time
> for things to work and that requires GPEs to be enabled before enumerating
> the PCI bus.
> 
> The first patch changes ACPICA to check the status of runtime GPEs before
> enabling them for the first time in order to avoid missing events (that
> is key for edge-triggered GPEs) and to process them early enough.
> 
> The second one makes it possible to change the ordering of initialization
> between GPEs and devices, and the third one actually changes that ordering.
> 
> The patches are based on Mika's work, so kudos to him.

Thank you for taking care of this! I've tested the series on Intel Skull
Canyon NUC, Dell XPS 9350, 9550 and 9365, and it fixes the issue on all
of them.

Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>

      parent reply	other threads:[~2017-08-10  9:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 22:29 [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan Rafael J. Wysocki
2017-08-09 22:30 ` [PATCH 1/3] ACPICA: Dispatch active GPEs at init time Rafael J. Wysocki
2017-08-10  1:48   ` Zheng, Lv
2017-08-10 16:06     ` Rafael J. Wysocki
2017-08-11  5:40       ` Zheng, Lv
2017-08-11 12:23         ` Rafael J. Wysocki
2017-08-15  9:59           ` Zheng, Lv
2017-08-15 12:21             ` Rafael J. Wysocki
2017-08-17  2:24               ` Zheng, Lv
2017-08-09 22:31 ` [PATCH 2/3] ACPICA: Make it possible to enable runtime GPEs earlier Rafael J. Wysocki
2017-08-10  1:52   ` Zheng, Lv
2017-08-10 16:07     ` Rafael J. Wysocki
2017-08-11  6:13       ` Zheng, Lv
2017-08-09 22:34 ` [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace Rafael J. Wysocki
2017-08-10  1:54   ` Zheng, Lv
2017-08-10  5:10   ` Lukas Wunner
2017-08-10  7:45     ` Zheng, Lv
2017-08-10  8:23     ` Mika Westerberg
2017-08-15  2:12   ` Zheng, Lv
2017-08-15 12:22     ` Rafael J. Wysocki
2017-08-17  2:25       ` Zheng, Lv
2017-08-10  9:34 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810093441.GQ2369@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox