From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Will Deacon <will.deacon@arm.com>,
Tomasz Nowicki <tn@semihalf.com>, Joerg Roedel <jroedel@suse.de>,
Sricharan R <sricharan@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Geetha Sowjanya <geethasowjanya.akula@cavium.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI/IORT: fix build regression without IOMMU
Date: Thu, 10 Aug 2017 15:24:30 +0100 [thread overview]
Message-ID: <20170810142430.GA17205@red-moon> (raw)
In-Reply-To: <20170810121114.2509560-1-arnd@arndb.de>
On Thu, Aug 10, 2017 at 02:11:00PM +0200, Arnd Bergmann wrote:
> A recent change reintroduced a bug that had previously been
> fixed by commit d49f2dedf33b ("ACPI/IORT: Fix CONFIG_IOMMU_API
> dependency"):
>
> drivers/acpi/arm64/iort.c: In function 'iort_iommu_configure':
> drivers/acpi/arm64/iort.c:829:26: error: 'struct iommu_fwspec' has no member named 'ops'
>
> This does the same change again, replacing another direct
> reference to iommu_fwspec->ops with a helper function call.
>
> Fixes: bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry Arnd, thanks, I will send it to Catalin straight away.
Lorenzo
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 9cdd49289786..9565d572f8dd 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -826,7 +826,7 @@ const struct iommu_ops *iort_iommu_configure(struct device *dev)
> * add_device callback for dev, replay it to get things in order.
> */
> if (!err) {
> - ops = dev->iommu_fwspec->ops;
> + ops = iort_fwspec_iommu_ops(dev->iommu_fwspec);
> err = iort_add_device_replay(ops, dev);
> }
>
> --
> 2.9.0
>
next prev parent reply other threads:[~2017-08-10 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 12:11 [PATCH] ACPI/IORT: fix build regression without IOMMU Arnd Bergmann
2017-08-10 14:24 ` Lorenzo Pieralisi [this message]
2017-08-28 9:27 ` Thorsten Leemhuis
2017-08-28 9:57 ` Lorenzo Pieralisi
2017-08-28 10:23 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810142430.GA17205@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=geethasowjanya.akula@cavium.com \
--cc=hanjun.guo@linaro.org \
--cc=jroedel@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=sricharan@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox