From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Boris Petkov <bp@suse.de>,
Tyler Baicar <tbaicar@codeaurora.org>,
Punit Agrawal <punit.agrawal@arm.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region
Date: Fri, 18 Aug 2017 01:30:47 +0100 [thread overview]
Message-ID: <20170818013047.427e38b7@alans-desktop> (raw)
In-Reply-To: <20170817213946.16939-1-tony.luck@intel.com>
On Thu, 17 Aug 2017 14:39:46 -0700
"Luck, Tony" <tony.luck@intel.com> wrote:
> From: Tony Luck <tony.luck@intel.com>
>
> The ACPI sysfs interface provides a way to read each ACPI table from
> userspace via entries in /sys/firmware/acpi/tables/
>
> The BERT table simply provides the size and address of the error
> record in BIOS reserved memory and users may want access to this
> record.
>
> In an earlier age we might have used /dev/mem to retrieve this error
> record, but many systems disable /dev/mem for security reasons.
>
> Extend this driver to provide read-only access to the data via a
> file in a new directory /sys/firmware/acpi/tables/data/BERT
Should this not also have a capability check. Assuming file permissions
are sufficient for grabbing a chunk of system memory holding error
info doesn't seem too scary but it's at odds with a lot of other cases ?
Alan
next prev parent reply other threads:[~2017-08-18 0:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:56 [PATCH] ACPI/APEI: Add BERT data driver Luck, Tony
2017-08-15 10:22 ` Punit Agrawal
2017-08-15 21:15 ` Luck, Tony
2017-08-16 13:14 ` Punit Agrawal
2017-08-16 15:22 ` Luck, Tony
2017-08-17 10:25 ` Punit Agrawal
2017-08-17 17:49 ` Luck, Tony
2017-08-17 19:28 ` Rafael J. Wysocki
2017-08-17 20:29 ` Luck, Tony
2017-08-17 20:41 ` Rafael J. Wysocki
2017-08-17 21:39 ` [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region Luck, Tony
2017-08-18 0:30 ` Alan Cox [this message]
2017-08-18 2:12 ` Luck, Tony
2017-08-23 14:56 ` Luck, Tony
2017-08-29 0:10 ` Kees Cook
2017-08-29 15:55 ` Luck, Tony
2017-08-18 17:38 ` Punit Agrawal
2017-08-18 23:19 ` [PATCH v4] " Luck, Tony
2017-08-28 20:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818013047.427e38b7@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rafael@kernel.org \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox