From: Borislav Petkov <bp@alien8.de>
To: Tyler Baicar <tbaicar@codeaurora.org>
Cc: rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com,
james.morse@arm.com, bp@suse.de, shiju.jose@huawei.com,
geliangtang@gmail.com, andriy.shevchenko@linux.intel.com,
tony.luck@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error
Date: Tue, 29 Aug 2017 10:16:10 +0200 [thread overview]
Message-ID: <20170829081610.moq2dtxzz4vrbmo5@pd.tnic> (raw)
In-Reply-To: <1503939221-27732-1-git-send-email-tbaicar@codeaurora.org>
On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote:
> Currently we acknowledge errors before clearing the error status.
> This could cause a new error to be populated by firmware in-between
> the error acknowledgment and the error status clearing which would
> cause the second error's status to be cleared without being handled.
> So, clear the error status before acknowledging the errors.
>
> Also, make sure to acknowledge the error if the error status read
> fails.
>
> V3: Seperate check for -ENOENT return value
>
> V2: Only send error ack if there was an error populated
> Remove curly braces that are no longer needed
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> ---
> drivers/acpi/apei/ghes.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-08-29 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 16:53 [PATCH V3] acpi: apei: clear error status before acknowledging the error Tyler Baicar
2017-08-28 17:01 ` Andy Shevchenko
2017-08-28 17:14 ` Borislav Petkov
2017-08-28 17:20 ` Andy Shevchenko
2017-08-28 17:25 ` Borislav Petkov
2017-08-28 17:44 ` Andy Shevchenko
2017-08-28 18:27 ` Borislav Petkov
2017-08-28 19:12 ` Andy Shevchenko
2017-08-28 19:14 ` Andy Shevchenko
2017-08-29 8:16 ` Borislav Petkov [this message]
2017-09-13 14:40 ` Baicar, Tyler
2017-09-21 15:27 ` Tyler Baicar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829081610.moq2dtxzz4vrbmo5@pd.tnic \
--to=bp@alien8.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=geliangtang@gmail.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox