From: Borislav Petkov <bp@suse.de>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, lorenzo.pieralisi@arm.com,
sudeep.holla@arm.com, linux-kernel@vger.kernel.org,
James Morse <james.morse@arm.com>
Subject: Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present
Date: Tue, 29 Aug 2017 17:32:02 +0200 [thread overview]
Message-ID: <20170829150219.4gg3443phihudvbv@pd.tnic> (raw)
In-Reply-To: <20170829132020.31471-1-punit.agrawal@arm.com>
On Tue, Aug 29, 2017 at 02:20:20PM +0100, Punit Agrawal wrote:
> According to the ACPI specification, firmware is not required to provide
> the Hardware Error Source Table (HEST). When HEST is not present, the
> following superfluous message is printed to the kernel boot log -
>
> [ 3.460067] GHES: HEST is not enabled!
>
> Extend hest_disable variable to track whether the firmware provides this
> table and if it is not present skip any log output. The existing
> behaviour is preserved in all other cases.
>
> Suggested-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: James Morse <james.morse@arm.com>
> ---
>
> Changes in v3:
> * Grouped hest_disable status checking into a switch/case for clarity
>
> drivers/acpi/apei/ghes.c | 7 ++++++-
> drivers/acpi/apei/hest.c | 13 +++++++------
> include/acpi/apei.h | 8 +++++++-
> 3 files changed, 20 insertions(+), 8 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-08-29 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 13:20 [PATCH v3] ACPI / APEI: Suppress message if HEST not present Punit Agrawal
2017-08-29 15:32 ` Borislav Petkov [this message]
2017-08-30 10:34 ` Punit Agrawal
2017-08-30 11:54 ` Rafael J. Wysocki
2017-08-30 12:54 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829150219.4gg3443phihudvbv@pd.tnic \
--to=bp@suse.de \
--cc=james.morse@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox