From: "Luck, Tony" <tony.luck@intel.com>
To: Kees Cook <keescook@google.com>
Cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Boris Petkov <bp@suse.de>,
Tyler Baicar <tbaicar@codeaurora.org>,
Punit Agrawal <punit.agrawal@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region
Date: Tue, 29 Aug 2017 08:55:56 -0700 [thread overview]
Message-ID: <20170829155554.fukyxs2x3b5evw37@intel.com> (raw)
In-Reply-To: <CAGXu5jLXGwbzxMEfbe-aaRos_kxnpnhOuErJx1j2qNwZvZZTag@mail.gmail.com>
On Mon, Aug 28, 2017 at 05:10:33PM -0700, Kees Cook wrote:
> On Wed, Aug 23, 2017 at 7:56 AM, Luck, Tony <tony.luck@intel.com> wrote:
> >>> Should this not also have a capability check. Assuming file permissions
> >>> are sufficient for grabbing a chunk of system memory holding error
> >>> info doesn't seem too scary but it's at odds with a lot of other cases ?
> >>
> >> At least one of those other cases (pstore) added a capability check and now regret
> >> it. There's a thread on reverting it. Look for:
> >>
> >> Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
> >
> > Here's at least part of that thread:
> >
> > https://marc.info/?l=linux-kernel&m=150301241114262&w=2
> >
> > Kees: you were OK with removing the capability check from pstore, right?
>
> Yeah, as long as there is comparable protections.
File system permission protection is "0400":
# ls -al /sys/firmware/acpi/tables/data
total 0
drwxr-xr-x. 2 root root 0 Aug 28 14:13 .
drwxr-xr-x. 4 root root 0 Aug 28 14:10 ..
-r--------. 1 root root 32768 Aug 28 14:13 BERT
-Tony
next prev parent reply other threads:[~2017-08-29 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:56 [PATCH] ACPI/APEI: Add BERT data driver Luck, Tony
2017-08-15 10:22 ` Punit Agrawal
2017-08-15 21:15 ` Luck, Tony
2017-08-16 13:14 ` Punit Agrawal
2017-08-16 15:22 ` Luck, Tony
2017-08-17 10:25 ` Punit Agrawal
2017-08-17 17:49 ` Luck, Tony
2017-08-17 19:28 ` Rafael J. Wysocki
2017-08-17 20:29 ` Luck, Tony
2017-08-17 20:41 ` Rafael J. Wysocki
2017-08-17 21:39 ` [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region Luck, Tony
2017-08-18 0:30 ` Alan Cox
2017-08-18 2:12 ` Luck, Tony
2017-08-23 14:56 ` Luck, Tony
2017-08-29 0:10 ` Kees Cook
2017-08-29 15:55 ` Luck, Tony [this message]
2017-08-18 17:38 ` Punit Agrawal
2017-08-18 23:19 ` [PATCH v4] " Luck, Tony
2017-08-28 20:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829155554.fukyxs2x3b5evw37@intel.com \
--to=tony.luck@intel.com \
--cc=bp@suse.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=keescook@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rafael@kernel.org \
--cc=tbaicar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox