Re: [RFC] et8ek8: Add support for flash and lens devices

Sakari Ailus
2017-09-09T22:06:10Z

Hi Pavel,

On Sat, Sep 09, 2017 at 11:47:24PM +0200, Pavel Machek wrote:
>
> Parse async sub-devices by using
> v4l2_subdev_fwnode_reference_parse_sensor_common().
>
> These types devices aren't directly related to the sensor, but are
> nevertheless handled by the et8ek8 driver due to the relationship of these
> component to the main part of the camera module --- the sensor.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz> # Not yet ready -- broken whitespace
>
> ---
>
> Whitespace is horribly bad. But otherwise... does it look ok?

It mostly mirrors the smiapp driver implementation and, well, is an issue.
Namely it's lacking releasing the notifier's resources, just like the
smiapp driver. I'll update the smiapp patch --- the notifier's resources
need to be released by calling v4l2_async_notifier_release(); see the 5th
patch.

Other than that it seems good.

--
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi