Re: [PATCH v9 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera

Pavel Machek
2017-09-09T18:32:43Z

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi!

> Add flash and indicator LED phandles to the sensor node.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

I'm adding similar support to et8ek8 and wonder.. why don't you also
add support for autofocus? Driver not yet available?

Thanks,
Pavel
> @@ -26,6 +26,7 @@
> clocks = <&isp 0>;
> clock-frequency = <9600000>;
> nokia,nvm-size = <(16 * 64)>;
> + flash-leds = <&as3645a_flash &as3645a_indicator>;
> port {
> smia_1_1: endpoint {
> link-frequencies = /bits/ 64 <199200000 210000000 499200000>;
> diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi b/arch/arm/boot/dts/omap3-n950-n9.dtsi
> index 1b0bd72945f2..12fbb3da5fce 100644
> --- a/arch/arm/boot/dts/omap3-n950-n9.dtsi
> +++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi
> @@ -271,14 +271,14 @@
> #size-cells = <0>;
> reg = <0x30>;
> compatible = "ams,as3645a";
> - flash@0 {
> + as3645a_flash: flash@0 {
> reg = <0x0>;
> flash-timeout-us = <150000>;
> flash-max-microamp = <320000>;
> led-max-microamp = <60000>;
> ams,input-max-microamp = <1750000>;
> };
> - indicator@1 {
> + as3645a_indicator: indicator@1 {
> reg = <0x1>;
> led-max-microamp = <10000>;
> };
> diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts
> index 646601a3ebd8..c354a1ed1e70 100644
> --- a/arch/arm/boot/dts/omap3-n950.dts
> +++ b/arch/arm/boot/dts/omap3-n950.dts
> @@ -60,6 +60,7 @@
> clocks = <&isp 0>;
> clock-frequency = <9600000>;
> nokia,nvm-size = <(16 * 64)>;
> + flash-leds = <&as3645a_flash &as3645a_indicator>;
> port {
> smia_1_1: endpoint {
> link-frequencies = /bits/ 64 <210000000 333600000 398400000>;

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]