public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Lin Ming <ming.m.lin@intel.com>, Tony Luck <tony.luck@intel.com>,
	Len Brown <len.brown@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-acpi@vger.kernel.org
Subject: IA64 and drivers/acpi/bus.c
Date: Mon, 25 Sep 2017 16:51:18 +0200	[thread overview]
Message-ID: <20170925165118.6ef312c2@endymion> (raw)

Hi all,

Long ago, a warning was silenced in drivers/acpi/bus.c on IA64 with
this commit:

commit cce4f632db200aef147c59084437168174b23f11
Author: Lin Ming <ming.m.lin@intel.com>
Date:   Wed May 12 09:26:48 2010 +0800

    ACPI: fix early DSDT dmi check warnings on ia64
    
I don't think this fix was particularly elegant, but it did the job at
the time. However you should be informed that an upcoming cleanup of
the dmi subsystem will cause the warning to resurface:

https://marc.info/?l=linux-kernel&m=150113709717948&w=2

Instead of checking for dmi_initialized on individual dmi_system_id
records, it will now be done once per dmi_check_system() call. It is
much more efficient, but one side effect is that the warning will be
displayed even if the array passed to dmi_check_system() is empty.

So the time has come to fix the problem cleanly, instead of just
silencing the warning. This can be done in 2 ways:

1* Don't call dmi_check_system() at all if not on X86.

2* Initialize DMI earlier on IA64, so it is ready when ACPI support
gets started.

I will let you guys decide what is the best option.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

             reply	other threads:[~2017-09-25 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 14:51 Jean Delvare [this message]
2017-09-29  4:42 ` IA64 and drivers/acpi/bus.c Zheng, Lv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925165118.6ef312c2@endymion \
    --to=jdelvare@suse.de \
    --cc=fenghua.yu@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox