From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-acpi@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, keescook@chromium.org, arnd@arndb.de,
dyoung@redhat.com, dave.jiang@intel.com, lv.zheng@intel.com,
rjw@rjwysocki.net, yasu.isimatu@gmail.com,
caoj.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com
Subject: Re: [POC] Extend "movable_node" to "movable_node=nn@ss" and add the interface in /sys to show the value
Date: Wed, 11 Oct 2017 17:14:52 +0800 [thread overview]
Message-ID: <20171011091452.GB15263@localhost.localdomain> (raw)
In-Reply-To: <20171011084215.GB9142@x1>
On Wed, Oct 11, 2017 at 04:42:15PM +0800, Baoquan He wrote:
>Hi dear Fan San,
Hi dear Uncle Bao,
>
>On 10/11/17 at 04:23pm, Chao Fan wrote:
>> On Wed, Oct 11, 2017 at 03:55:13PM +0800, Baoquan He wrote:
>> >Hi Fan San,
>> >> 1. Get and parse the srat table before kernel extracted, then mark the memory
>> >> region in movable node which should be avoided in kaslr.
>> >> I have send the patch:
>> >> https://www.spinics.net/lists/kernel/msg2595546.html
>> >> But the change is large and then here is the second method.
>> >>
>> >> 2. Extend the movable_node to movable_node=nn@ss, in which nn means
>> >> the size of memory in immovable node, and ss means the start position of
>> >> this memory region.
>> >> But it brings another question, it may be a little difficult for a normal
>> >> user to specify the nn and ss. Because it's hard for a user to know the value
>> >> of the memory in immovable node.
>> >> So I wonder if it's good to add a interface in /sys, like:
>> >> # cat /sys/device/system/memory/immovable_node
>> >
>> Hi Baoquan,
>>
>> Thanks for your reply,
>>
>> >You can post patch. By the way, can the existing
>> >/sys/devices/system/memory/memoryX/removable be used instead?
>>
>> I ever search the interfaces of /sys/devices/system/memory/, and noticed
>> this "removable", it does be able to help us judge it's removable or not.
>> But we should also get the information of the memory length and start position
>> by other interface. If there is a interface that show the nn and ss, we
>> can use them and change grub directly.
>> And there are more "memoryX" in one node. In my machine, I can see
>> memory0(linked to /sys/devices/system/memory/memory0) - memory7 in
>> /sys/devices/system/node/node0. And total memory38 for 4 nodes. I think
>> it's a little heavy to handle every memoryX.
>> But in SRAT table, one node has one or two memory regions. So I thinks
>> it's more straight and easy to use. How do you think about it?
>
>I am fine, I just mention it.
OK, I just explain I did not find the suitable existing interface.
>
>Then please show your code envelopped in well formatted patch.
OK, will try to make it.
Thanks,
Chao Fan
>
>Thanks
>Baoquan
>
>> >
>> >> nn@ss
>> >> nn@ss
>> >> ...
>> >> to show the two value.
>> >> When srat table is parsed in acpi_parse_memory_affinity, fill the value
>> >> and user can get and use them.
>> >>
>> >> If anyone has a better method, please let me know.
>> >> Any comments will be welcome.
>> >>
>> >> Thanks,
>> >> Chao Fan
>> >>
>> >>
>> >
>> >
>>
>>
>
>
prev parent reply other threads:[~2017-10-11 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 2:28 [POC] Extend "movable_node" to "movable_node=nn@ss" and add the interface in /sys to show the value Chao Fan
2017-10-11 7:55 ` Baoquan He
2017-10-11 8:23 ` Chao Fan
2017-10-11 8:42 ` Baoquan He
2017-10-11 9:14 ` Chao Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011091452.GB15263@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=dave.jiang@intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lv.zheng@intel.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).