From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, maxime.ripard@free-electrons.com,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
pavel@ucw.cz, sre@kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v16 25/32] v4l: fwnode: Add convenience function for parsing common external refs
Date: Thu, 26 Oct 2017 10:53:35 +0300 [thread overview]
Message-ID: <20171026075342.5760-26-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20171026075342.5760-1-sakari.ailus@linux.intel.com>
Add v4l2_fwnode_parse_reference_sensor_common for parsing common
sensor properties that refer to adjacent devices such as flash or lens
driver chips.
As this is an association only, there's little a regular driver needs to
know about these devices as such.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++
include/media/v4l2-async.h | 3 ++-
include/media/v4l2-fwnode.h | 21 +++++++++++++++++++++
3 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index 845ef8da9002..1234bd1a2f49 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -865,6 +865,41 @@ static int v4l2_fwnode_reference_parse_int_props(
return ret;
}
+int v4l2_async_notifier_parse_fwnode_sensor_common(
+ struct device *dev, struct v4l2_async_notifier *notifier)
+{
+ static const char * const led_props[] = { "led" };
+ static const struct {
+ const char * const name;
+ const char **props;
+ unsigned int nprops;
+ } props[] = {
+ { "flash-leds", led_props, ARRAY_SIZE(led_props) },
+ { "lens-focus", NULL, 0 },
+ };
+ unsigned int i;
+
+ for (i = 0; i < ARRAY_SIZE(props); i++) {
+ int ret;
+
+ if (props[i].props && is_acpi_node(dev_fwnode(dev)))
+ ret = v4l2_fwnode_reference_parse_int_props(
+ dev, notifier, props[i].name,
+ props[i].props, props[i].nprops);
+ else
+ ret = v4l2_fwnode_reference_parse(
+ dev, notifier, props[i].name);
+ if (ret && ret != -ENOENT) {
+ dev_warn(dev, "parsing property \"%s\" failed (%d)\n",
+ props[i].name, ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(v4l2_async_notifier_parse_fwnode_sensor_common);
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Sakari Ailus <sakari.ailus@linux.intel.com>");
MODULE_AUTHOR("Sylwester Nawrocki <s.nawrocki@samsung.com>");
diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
index 17c4ac7c73e8..8d8cfc3f3100 100644
--- a/include/media/v4l2-async.h
+++ b/include/media/v4l2-async.h
@@ -156,7 +156,8 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier);
* Release memory resources related to a notifier, including the async
* sub-devices allocated for the purposes of the notifier but not the notifier
* itself. The user is responsible for calling this function to clean up the
- * notifier after calling @v4l2_async_notifier_parse_fwnode_endpoints.
+ * notifier after calling @v4l2_async_notifier_parse_fwnode_endpoints or
+ * @v4l2_fwnode_reference_parse_sensor_common.
*
* There is no harm from calling v4l2_async_notifier_cleanup in other
* cases as long as its memory has been zeroed after it has been
diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
index 105cfeee44ef..ca50108dfd8f 100644
--- a/include/media/v4l2-fwnode.h
+++ b/include/media/v4l2-fwnode.h
@@ -319,4 +319,25 @@ int v4l2_async_notifier_parse_fwnode_endpoints_by_port(
struct v4l2_fwnode_endpoint *vep,
struct v4l2_async_subdev *asd));
+/**
+ * v4l2_fwnode_reference_parse_sensor_common - parse common references on
+ * sensors for async sub-devices
+ * @dev: the device node the properties of which are parsed for references
+ * @notifier: the async notifier where the async subdevs will be added
+ *
+ * Parse common sensor properties for remote devices related to the
+ * sensor and set up async sub-devices for them.
+ *
+ * Any notifier populated using this function must be released with a call to
+ * v4l2_async_notifier_release() after it has been unregistered and the async
+ * sub-devices are no longer in use, even in the case the function returned an
+ * error.
+ *
+ * Return: 0 on success
+ * -ENOMEM if memory allocation failed
+ * -EINVAL if property parsing failed
+ */
+int v4l2_async_notifier_parse_fwnode_sensor_common(
+ struct device *dev, struct v4l2_async_notifier *notifier);
+
#endif /* _V4L2_FWNODE_H */
--
2.11.0
next prev parent reply other threads:[~2017-10-26 7:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 7:53 [PATCH v16 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 01/32] v4l: async: Remove re-probing support Sakari Ailus
2017-10-26 15:20 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup Sakari Ailus
[not found] ` <20171026075342.5760-3-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 15:23 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister() Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 05/32] v4l: async: Correctly serialise async sub-device unregistration Sakari Ailus
[not found] ` <20171026075342.5760-6-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 15:38 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 07/32] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 08/32] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
2017-10-26 21:35 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 09/32] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
[not found] ` <20171026075342.5760-10-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-27 14:46 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 10/32] rcar-vin: " Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 11/32] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-10-27 14:47 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 12/32] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-10-27 14:47 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 13/32] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-10-26 21:44 ` Niklas Söderlund
2017-10-27 14:47 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 14/32] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
2017-10-26 21:46 ` Niklas Söderlund
2017-10-27 14:48 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 15/32] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
[not found] ` <20171026075342.5760-16-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 21:52 ` Niklas Söderlund
2017-10-27 14:49 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 16/32] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
[not found] ` <20171026075342.5760-17-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 22:00 ` Niklas Söderlund
2017-10-27 14:49 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 17/32] v4l: async: Prepare for async sub-device notifiers Sakari Ailus
2017-10-26 22:10 ` Niklas Söderlund
2017-10-27 8:10 ` Niklas Söderlund
2017-10-27 8:30 ` Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 18/32] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers Sakari Ailus
2017-10-27 9:52 ` Niklas Söderlund
[not found] ` <20171027095227.GA8854-ofJ5d6taAgIKcZgyrm77+z0dHWC0CY5B@public.gmane.org>
2017-10-27 10:06 ` Sakari Ailus
2017-10-27 10:26 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 20/32] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
[not found] ` <20171026075342.5760-21-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-29 22:26 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 21/32] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 22/32] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-10-29 22:28 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 23/32] v4l: fwnode: Add a helper function for parsing generic references Sakari Ailus
2017-10-27 10:30 ` Niklas Söderlund
2017-10-29 22:53 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 24/32] v4l: fwnode: Add a helper function to obtain device / integer references Sakari Ailus
2017-10-26 7:53 ` Sakari Ailus [this message]
[not found] ` <20171026075342.5760-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 7:53 ` [PATCH v16 04/32] v4l: async: Fix notifier complete callback error handling Sakari Ailus
[not found] ` <20171026075342.5760-5-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 15:34 ` Niklas Söderlund
2017-10-27 14:46 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 06/32] v4l: async: Use more intuitive names for internal functions Sakari Ailus
[not found] ` <20171026075342.5760-7-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 15:39 ` Niklas Söderlund
2017-10-26 7:53 ` [PATCH v16 26/32] v4l: fwnode: Add a convenience function for registering sensors Sakari Ailus
2017-10-27 13:06 ` Niklas Söderlund
2017-10-29 23:02 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 27/32] dt: bindings: smiapp: Document lens-focus and flash-leds properties Sakari Ailus
2017-10-27 14:38 ` Rob Herring
[not found] ` <20171026075342.5760-28-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-29 23:03 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 28/32] smiapp: Add support for flash and lens devices Sakari Ailus
2017-10-29 23:04 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 30/32] ov5670: " Sakari Ailus
2017-10-29 23:05 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 29/32] et8ek8: " Sakari Ailus
2017-10-29 23:05 ` Sebastian Reichel
2017-11-12 11:27 ` et8ek8: Document " Pavel Machek
2017-11-12 14:25 ` Sebastian Reichel
2017-11-13 17:05 ` Sakari Ailus
2017-10-26 7:53 ` [PATCH v16 31/32] ov13858: Add " Sakari Ailus
[not found] ` <20171026075342.5760-32-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-29 23:06 ` Sebastian Reichel
2017-10-26 7:53 ` [PATCH v16 32/32] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
2017-10-29 23:08 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026075342.5760-26-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox