Re: [PATCH v16 12/32] omap3isp: Print the name of the entity where no source pads could be found

Sebastian Reichel
2017-10-27T14:47:46Z

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Hi,

On Thu, Oct 26, 2017 at 10:53:22AM +0300, Sakari Ailus wrote:
> If no source pads are found in an entity, print the name of the entity.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> drivers/media/platform/omap3isp/isp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 4afd7ba4fad6..35687c9707e0 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -1669,8 +1669,8 @@ static int isp_link_entity(
> break;
> }
> if (i == entity->num_pads) {
> - dev_err(isp->dev, "%s: no source pad in external entity\n",
> - __func__);
> + dev_err(isp->dev, "%s: no source pad in external entity %s\n",
> + __func__, entity->name);
> return -EINVAL;
> }
>
> --
> 2.11.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]