From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas =?iso-8859-1?Q?S=F6derlund?= Subject: Re: [PATCH v16 06/32] v4l: async: Use more intuitive names for internal functions Date: Thu, 26 Oct 2017 17:39:30 +0200 Message-ID: <20171026153930.GE2297@bigcity.dyn.berto.se> References: <20171026075342.5760-1-sakari.ailus@linux.intel.com> <20171026075342.5760-7-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20171026075342.5760-7-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sakari Ailus Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org On 2017-10-26 10:53:16 +0300, Sakari Ailus wrote: > Rename internal functions to make the names of the functions better > describe what they do. > > Old name New name > v4l2_async_test_notify v4l2_async_match_notify > v4l2_async_belongs v4l2_async_find_match > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek > Reviewed-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel Acked-by: Niklas Söderlund > --- > drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index cde2cf2ab4b0..8b84fea50c2a 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -60,8 +60,8 @@ static LIST_HEAD(subdev_list); > static LIST_HEAD(notifier_list); > static DEFINE_MUTEX(list_lock); > > -static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *notifier, > - struct v4l2_subdev *sd) > +static struct v4l2_async_subdev *v4l2_async_find_match( > + struct v4l2_async_notifier *notifier, struct v4l2_subdev *sd) > { > bool (*match)(struct v4l2_subdev *, struct v4l2_async_subdev *); > struct v4l2_async_subdev *asd; > @@ -95,9 +95,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier * > return NULL; > } > > -static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier, > - struct v4l2_subdev *sd, > - struct v4l2_async_subdev *asd) > +static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier, > + struct v4l2_subdev *sd, > + struct v4l2_async_subdev *asd) > { > int ret; > > @@ -187,11 +187,11 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev, > list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) { > int ret; > > - asd = v4l2_async_belongs(notifier, sd); > + asd = v4l2_async_find_match(notifier, sd); > if (!asd) > continue; > > - ret = v4l2_async_test_notify(notifier, sd, asd); > + ret = v4l2_async_match_notify(notifier, sd, asd); > if (ret < 0) { > mutex_unlock(&list_lock); > return ret; > @@ -255,13 +255,14 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd) > INIT_LIST_HEAD(&sd->async_list); > > list_for_each_entry(notifier, ¬ifier_list, list) { > - struct v4l2_async_subdev *asd = v4l2_async_belongs(notifier, sd); > + struct v4l2_async_subdev *asd = v4l2_async_find_match(notifier, > + sd); > int ret; > > if (!asd) > continue; > > - ret = v4l2_async_test_notify(notifier, sd, asd); > + ret = v4l2_async_match_notify(notifier, sd, asd); > if (ret) > goto err_unlock; > > -- > 2.11.0 > -- Regards, Niklas Söderlund -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html