From: "Christoph Böhmwalder" <christoph@boehmwalder.at>
To: Ognjen Galic <smclt30p@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
linux-acpi@vger.kernel.org, devel@acpica.org,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3 v5] battery: Add the battery hooking API
Date: Mon, 11 Dec 2017 18:52:58 +0100 [thread overview]
Message-ID: <20171211175258.eewj7rmtqmk6hznf@localhost> (raw)
In-Reply-To: <20171211163945.GA23317@thinkpad>
On Mon, Dec 11, 2017 at 05:39:45PM +0100, Ognjen Galic wrote:
> The 80-char warning can be omitted if the line looks ugly when broken.
> This is noted in the style guide.
Indeed, you're right here. The line is just barely over 80 characters
anyway, so it really doesn't matter here.
> About the MAINTAINERS file, I don't know how, when or why to edit that
> file so I did not touch it.
That was just a warning about you moving drivers/acpi/battery.h to
include/acpi/battery.h, which could potentially lead to an edit to
MAINTAINERS being neccessary. I just double-checked this and the
include/acpi/ path was already listed in the MAINTAINERS file, so you're
good.
next prev parent reply other threads:[~2017-12-11 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 18:01 [PATCH 1/3 v5] battery: Add the battery hooking API Ognjen Galic
2017-12-11 12:03 ` Christoph Böhmwalder
2017-12-11 16:39 ` Ognjen Galic
2017-12-11 17:52 ` Christoph Böhmwalder [this message]
2017-12-12 18:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211175258.eewj7rmtqmk6hznf@localhost \
--to=christoph@boehmwalder.at \
--cc=andy@infradead.org \
--cc=devel@acpica.org \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=smclt30p@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox