* ACPI: sbshc: remove raw pointer from printk message
@ 2018-01-19 9:06 Greg Kroah-Hartman
2018-01-19 23:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-19 9:06 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown; +Cc: linux-acpi, linux-kernel, Wang Qize
There's no need to be printing a raw kernel pointer to the kernel log at
every boot. So just remove it, and change the whole message to use the
correct dev_info() call at the same time.
Reported-by: Wang Qize <wang_qize@venustech.com.cn>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c
index 2fa8304171e0..217e1caf58d6 100644
--- a/drivers/acpi/sbshc.c
+++ b/drivers/acpi/sbshc.c
@@ -275,8 +275,8 @@ static int acpi_smbus_hc_add(struct acpi_device *device)
device->driver_data = hc;
acpi_ec_add_query_handler(hc->ec, hc->query_bit, NULL, smbus_alarm, hc);
- printk(KERN_INFO PREFIX "SBS HC: EC = 0x%p, offset = 0x%0x, query_bit = 0x%0x\n",
- hc->ec, hc->offset, hc->query_bit);
+ dev_info(&device->dev, "SBS HC: offset = 0x%0x, query_bit = 0x%0x\n",
+ hc->offset, hc->query_bit);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: ACPI: sbshc: remove raw pointer from printk message
2018-01-19 9:06 ACPI: sbshc: remove raw pointer from printk message Greg Kroah-Hartman
@ 2018-01-19 23:53 ` Rafael J. Wysocki
2018-01-20 7:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2018-01-19 23:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wang Qize
On Fri, Jan 19, 2018 at 10:06 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There's no need to be printing a raw kernel pointer to the kernel log at
> every boot. So just remove it, and change the whole message to use the
> correct dev_info() call at the same time.
>
> Reported-by: Wang Qize <wang_qize@venustech.com.cn>
> Cc: stable <stable@vger.kernel.org>
I will remember this one. ;-)
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c
> index 2fa8304171e0..217e1caf58d6 100644
> --- a/drivers/acpi/sbshc.c
> +++ b/drivers/acpi/sbshc.c
> @@ -275,8 +275,8 @@ static int acpi_smbus_hc_add(struct acpi_device *device)
> device->driver_data = hc;
>
> acpi_ec_add_query_handler(hc->ec, hc->query_bit, NULL, smbus_alarm, hc);
> - printk(KERN_INFO PREFIX "SBS HC: EC = 0x%p, offset = 0x%0x, query_bit = 0x%0x\n",
> - hc->ec, hc->offset, hc->query_bit);
> + dev_info(&device->dev, "SBS HC: offset = 0x%0x, query_bit = 0x%0x\n",
> + hc->offset, hc->query_bit);
>
> return 0;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ACPI: sbshc: remove raw pointer from printk message
2018-01-19 23:53 ` Rafael J. Wysocki
@ 2018-01-20 7:36 ` Greg Kroah-Hartman
2018-01-20 8:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-20 7:36 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wang Qize
On Sat, Jan 20, 2018 at 12:53:39AM +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 19, 2018 at 10:06 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > There's no need to be printing a raw kernel pointer to the kernel log at
> > every boot. So just remove it, and change the whole message to use the
> > correct dev_info() call at the same time.
> >
> > Reported-by: Wang Qize <wang_qize@venustech.com.cn>
> > Cc: stable <stable@vger.kernel.org>
>
> I will remember this one. ;-)
>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Does that mean you want me to take this through my tree? Or is there an
acpi tree it will go through?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ACPI: sbshc: remove raw pointer from printk message
2018-01-20 7:36 ` Greg Kroah-Hartman
@ 2018-01-20 8:03 ` Rafael J. Wysocki
2018-01-20 8:16 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2018-01-20 8:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, Rafael J. Wysocki, Len Brown,
ACPI Devel Maling List, Linux Kernel Mailing List, Wang Qize
On Sat, Jan 20, 2018 at 8:36 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sat, Jan 20, 2018 at 12:53:39AM +0100, Rafael J. Wysocki wrote:
>> On Fri, Jan 19, 2018 at 10:06 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > There's no need to be printing a raw kernel pointer to the kernel log at
>> > every boot. So just remove it, and change the whole message to use the
>> > correct dev_info() call at the same time.
>> >
>> > Reported-by: Wang Qize <wang_qize@venustech.com.cn>
>> > Cc: stable <stable@vger.kernel.org>
>>
>> I will remember this one. ;-)
>>
>> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Does that mean you want me to take this through my tree? Or is there an
> acpi tree it will go through?
I thought you'd push it, but I can take it, of course. For 4.16, though.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ACPI: sbshc: remove raw pointer from printk message
2018-01-20 8:03 ` Rafael J. Wysocki
@ 2018-01-20 8:16 ` Greg Kroah-Hartman
[not found] ` <2018012211145163626812@venustech.com.cn>
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-20 8:16 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wang Qize
On Sat, Jan 20, 2018 at 09:03:33AM +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 20, 2018 at 8:36 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sat, Jan 20, 2018 at 12:53:39AM +0100, Rafael J. Wysocki wrote:
> >> On Fri, Jan 19, 2018 at 10:06 AM, Greg Kroah-Hartman
> >> <gregkh@linuxfoundation.org> wrote:
> >> > There's no need to be printing a raw kernel pointer to the kernel log at
> >> > every boot. So just remove it, and change the whole message to use the
> >> > correct dev_info() call at the same time.
> >> >
> >> > Reported-by: Wang Qize <wang_qize@venustech.com.cn>
> >> > Cc: stable <stable@vger.kernel.org>
> >>
> >> I will remember this one. ;-)
> >>
> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>
> >> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Does that mean you want me to take this through my tree? Or is there an
> > acpi tree it will go through?
>
> I thought you'd push it, but I can take it, of course. For 4.16, though.
4.16 is fine, the issue has been around for a very long time, no rush :)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-22 7:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 9:06 ACPI: sbshc: remove raw pointer from printk message Greg Kroah-Hartman
2018-01-19 23:53 ` Rafael J. Wysocki
2018-01-20 7:36 ` Greg Kroah-Hartman
2018-01-20 8:03 ` Rafael J. Wysocki
2018-01-20 8:16 ` Greg Kroah-Hartman
[not found] ` <2018012211145163626812@venustech.com.cn>
2018-01-22 7:18 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).