From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ognjen =?utf-8?B?R2FsacSH?= Subject: Re: [2/4] ACPI / battery: reorder headers alphabetically Date: Sat, 27 Jan 2018 08:29:40 +0100 Message-ID: <20180127072940.GA839@thinkpad> References: <20180113115331.GA13662@thinkpad> <1515930919.7000.984.camel@linux.intel.com> <20180114235033.GA10002@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:51697 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbeA0H3q (ORCPT ); Sat, 27 Jan 2018 02:29:46 -0500 Received: by mail-wm0-f49.google.com with SMTP id r71so5151776wmd.1 for ; Fri, 26 Jan 2018 23:29:45 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Andy Shevchenko , Dmitry Rozhkov , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List On Mon, Jan 15, 2018 at 01:06:47AM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 15, 2018 at 12:50 AM, Ognjen Galić wrote: > > On Mon, Jan 15, 2018 at 12:40:13AM +0100, Rafael J. Wysocki wrote: > >> On Sun, Jan 14, 2018 at 12:55 PM, Andy Shevchenko > >> wrote: > >> > On Sat, 2018-01-13 at 12:53 +0100, Ognjen Galić wrote: > >> >> > -#include > >> >> > -#include > >> >> > -#include > >> >> > -#include > >> >> > #include > >> >> > -#include > >> >> > #include > >> >> > +#include > >> >> > +#include > >> >> > +#include > >> >> > +#include > >> >> > #include > >> >> > #include > >> >> > -#include > >> >> > +#include > >> >> > >> >> These changes completely break my patch: > >> >> https://patchwork.kernel.org/patch/10142157/ > >> >> > >> >> Can we please postpone this patch until I hear back from Rafael > >> >> about my series, as my series does some of the things this patch > >> >> series does (like defining pr_fmt to shorten log prints) and this > >> >> is a much smaller changeset and would require small changes on > >> >> conflicts compared to my series? > >> > > >> > Definitely on both series we need to hear from Rafael. > >> > >> Right, I still need to convince myself that the Ognjen's series > >> actually works in all cases which I'm not quite sure about ATM. > > > > What edge cases are you concerned about? > > Initialization ordering, basically. > > It appears to work only under specific assumptions that are not > guaranteed to be satisfied universally, but I need to walk though it > again to check that. Well, any updates? It's been a while.