From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: dmaengine <dmaengine@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sinan Kaya <okaya@codeaurora.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH v1 3/4] dmaengine: hidma: Constify returned by device_get_match_data() value
Date: Wed, 31 Jan 2018 23:29:58 +0200 [thread overview]
Message-ID: <20180131212959.68766-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20180131212959.68766-1-andriy.shevchenko@linux.intel.com>
The value under the hood is constant in any case.
It makes sense to show this explicitly.
Fixes: 95fbfb7aa28d ("dmaengine: qcom_hidma: Add support for the new revision")
Cc: Sinan Kaya <okaya@codeaurora.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/qcom/hidma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 963cc5228d05..24e163cefb7c 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -743,9 +743,9 @@ static int hidma_request_msi(struct hidma_dev *dmadev,
static bool hidma_test_capability(struct device *dev, enum hidma_cap test_cap)
{
- enum hidma_cap cap;
+ const enum hidma_cap cap;
- cap = (enum hidma_cap) device_get_match_data(dev);
+ cap = (const enum hidma_cap) device_get_match_data(dev);
return cap ? ((cap & test_cap) > 0) : 0;
}
--
2.15.1
next prev parent reply other threads:[~2018-01-31 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:29 [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-01-31 21:29 ` [PATCH v1 2/4] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-01-31 21:29 ` Andy Shevchenko [this message]
2018-02-03 17:16 ` [PATCH v1 3/4] dmaengine: hidma: Constify returned by device_get_match_data() value kbuild test robot
2018-01-31 21:29 ` [PATCH v1 4/4] device property: Constify device_get_match_data() Andy Shevchenko
2018-01-31 22:17 ` [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Sinan Kaya
2018-02-01 7:27 ` Rafael J. Wysocki
2018-02-01 12:24 ` Andy Shevchenko
2018-02-01 12:58 ` okaya
2018-02-02 11:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131212959.68766-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).