From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: dmaengine <dmaengine@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sinan Kaya <okaya@codeaurora.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case
Date: Thu, 1 Feb 2018 22:20:07 +0200 [thread overview]
Message-ID: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> (raw)
Instead of playing tricks with last invalid entry,
return simple -ENODATA error code casted to pointer.
It would be good for future in case caller passes NULL pointer for
ID table. Moreover, caller can check the code to be sure what happened
inside callee.
Fixes: 2b9c698efa58 ("ACPI / scan: Take the PRP0001 position in the list of IDs into account")
Cc: Sinan Kaya <okaya@codeaurora.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: new patch
drivers/acpi/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index f87ed3be779a..a87a97bf75f8 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -762,7 +762,7 @@ static const struct acpi_device_id *__acpi_match_device(
*/
if (!strcmp(ACPI_DT_NAMESPACE_HID, hwid->id)
&& acpi_of_match_device(device, of_ids))
- return id;
+ return ERR_PTR(-ENODATA);
}
return NULL;
}
--
2.15.1
next reply other threads:[~2018-02-01 20:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:20 Andy Shevchenko [this message]
2018-02-01 20:20 ` [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-01 20:32 ` Sinan Kaya
2018-02-01 20:40 ` Andy Shevchenko
2018-02-01 20:45 ` Andy Shevchenko
2018-02-04 7:18 ` Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
2018-02-05 15:59 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-01 20:46 ` Andy Shevchenko
2018-02-04 7:21 ` Rafael J. Wysocki
2018-02-05 16:04 ` Andy Shevchenko
2018-02-05 16:54 ` Rafael J. Wysocki
2018-02-06 12:51 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-02-04 7:23 ` Rafael J. Wysocki
2018-02-05 16:12 ` Andy Shevchenko
2018-02-05 16:53 ` Rafael J. Wysocki
2018-02-01 20:20 ` [PATCH v2 5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-04 14:06 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 6/6] device property: Constify device_get_match_data() Andy Shevchenko
2018-02-01 20:35 ` Sinan Kaya
2018-02-01 20:38 ` Andy Shevchenko
2018-02-01 20:40 ` Sinan Kaya
2018-02-01 21:23 ` Sakari Ailus
2018-02-04 7:16 ` [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201202012.36524-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).