From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 2/3] GHES: add a notify chain for process memory section Date: Wed, 7 Feb 2018 11:31:46 +0100 Message-ID: <20180207103145.GC8944@pd.tnic> References: <1516969885-150532-1-git-send-email-xiexiuqi@huawei.com> <1516969885-150532-3-git-send-email-xiexiuqi@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1516969885-150532-3-git-send-email-xiexiuqi@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Xie XiuQi Cc: catalin.marinas@arm.com, will.deacon@arm.com, mingo@redhat.com, mark.rutland@arm.com, ard.biesheuvel@linaro.org, james.morse@arm.com, Dave.Martin@arm.com, takahiro.akashi@linaro.org, tbaicar@codeaurora.org, stephen.boyd@linaro.org, julien.thierry@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, wangxiongfeng2@huawei.com, zhengqiang10@huawei.com, gengdongjiu@huawei.com, huawei.libin@huawei.com, wangkefeng.wang@huawei.com, lijinyue@huawei.com, guohanjun@huawei.com, hanjun.guo@linaro.org, cj.chengjian@huawei.com List-Id: linux-acpi@vger.kernel.org On Fri, Jan 26, 2018 at 08:31:24PM +0800, Xie XiuQi wrote: > Add a notify chain for process memory section, with > which other modules might do error recovery. > > Signed-off-by: Xie XiuQi > Tested-by: Wang Xiongfeng > Tested-by: Tyler Baicar > --- > drivers/acpi/apei/ghes.c | 10 ++++++++++ > include/acpi/ghes.h | 8 ++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index cff671d..1f0ebfb 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -109,6 +109,9 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes) > static LIST_HEAD(ghes_hed); > static DEFINE_MUTEX(ghes_list_mutex); > > +ATOMIC_NOTIFIER_HEAD(ghes_mem_err_chain); > +EXPORT_SYMBOL(ghes_mem_err_chain); Definitely not EXPORT_SYMBOL. And certainly not export the notifier head. Have register and unregister functions instead. That is, *if* you can't solve it differently with James. Notifiers should be avoided if possible. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --