linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: kbuild-all@01.org, linux-acpi@vger.kernel.org, devel@acpica.org,
	linux-pm@vger.kernel.org
Subject: [pm:linux-next 23/25] drivers/acpi/ec.c:1936:12: error: redefinition of 'acpi_ec_suspend_noirq'
Date: Thu, 8 Feb 2018 00:14:53 +0800	[thread overview]
Message-ID: <201802080051.FW6lumI7%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3928 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
head:   fcc24b97be0fe8c21fff1204fdd8fbbd1dbc4025
commit: 6fb1673a17fcbed275aea24a6e483e64fff1a2c5 [23/25] Revert "ACPI / EC: Drop EC noirq hooks to fix a regression"
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 6fb1673a17fcbed275aea24a6e483e64fff1a2c5
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/acpi/ec.c:1936:12: error: redefinition of 'acpi_ec_suspend_noirq'
    static int acpi_ec_suspend_noirq(struct device *dev)
               ^~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/ec.c:1908:12: note: previous definition of 'acpi_ec_suspend_noirq' was here
    static int acpi_ec_suspend_noirq(struct device *dev)
               ^~~~~~~~~~~~~~~~~~~~~
>> drivers/acpi/ec.c:1951:12: error: redefinition of 'acpi_ec_resume_noirq'
    static int acpi_ec_resume_noirq(struct device *dev)
               ^~~~~~~~~~~~~~~~~~~~
   drivers/acpi/ec.c:1917:12: note: previous definition of 'acpi_ec_resume_noirq' was here
    static int acpi_ec_resume_noirq(struct device *dev)
               ^~~~~~~~~~~~~~~~~~~~
   drivers/acpi/ec.c:1917:12: warning: 'acpi_ec_resume_noirq' defined but not used [-Wunused-function]
   drivers/acpi/ec.c:1908:12: warning: 'acpi_ec_suspend_noirq' defined but not used [-Wunused-function]
    static int acpi_ec_suspend_noirq(struct device *dev)
               ^~~~~~~~~~~~~~~~~~~~~

vim +/acpi_ec_suspend_noirq +1936 drivers/acpi/ec.c

39a2a2aa Lv Zheng          2016-08-03  1935  
76380636 Rafael J. Wysocki 2017-07-19 @1936  static int acpi_ec_suspend_noirq(struct device *dev)
76380636 Rafael J. Wysocki 2017-07-19  1937  {
76380636 Rafael J. Wysocki 2017-07-19  1938  	struct acpi_ec *ec = acpi_driver_data(to_acpi_device(dev));
76380636 Rafael J. Wysocki 2017-07-19  1939  
76380636 Rafael J. Wysocki 2017-07-19  1940  	/*
76380636 Rafael J. Wysocki 2017-07-19  1941  	 * The SCI handler doesn't run at this point, so the GPE can be
76380636 Rafael J. Wysocki 2017-07-19  1942  	 * masked at the low level without side effects.
76380636 Rafael J. Wysocki 2017-07-19  1943  	 */
76380636 Rafael J. Wysocki 2017-07-19  1944  	if (ec_no_wakeup && test_bit(EC_FLAGS_STARTED, &ec->flags) &&
76380636 Rafael J. Wysocki 2017-07-19  1945  	    ec->reference_count >= 1)
76380636 Rafael J. Wysocki 2017-07-19  1946  		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
76380636 Rafael J. Wysocki 2017-07-19  1947  
76380636 Rafael J. Wysocki 2017-07-19  1948  	return 0;
76380636 Rafael J. Wysocki 2017-07-19  1949  }
76380636 Rafael J. Wysocki 2017-07-19  1950  
76380636 Rafael J. Wysocki 2017-07-19 @1951  static int acpi_ec_resume_noirq(struct device *dev)
76380636 Rafael J. Wysocki 2017-07-19  1952  {
76380636 Rafael J. Wysocki 2017-07-19  1953  	struct acpi_ec *ec = acpi_driver_data(to_acpi_device(dev));
76380636 Rafael J. Wysocki 2017-07-19  1954  
76380636 Rafael J. Wysocki 2017-07-19  1955  	if (ec_no_wakeup && test_bit(EC_FLAGS_STARTED, &ec->flags) &&
76380636 Rafael J. Wysocki 2017-07-19  1956  	    ec->reference_count >= 1)
76380636 Rafael J. Wysocki 2017-07-19  1957  		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_ENABLE);
76380636 Rafael J. Wysocki 2017-07-19  1958  
76380636 Rafael J. Wysocki 2017-07-19  1959  	return 0;
76380636 Rafael J. Wysocki 2017-07-19  1960  }
76380636 Rafael J. Wysocki 2017-07-19  1961  

:::::: The code at line 1936 was first introduced by commit
:::::: 76380636280b46541a9d2fe5aac497475bfbcde8 ACPI / EC: Add parameter to force disable the GPE on suspend

:::::: TO: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40520 bytes --]

             reply	other threads:[~2018-02-07 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 16:14 kbuild test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-02-07 19:45 [pm:linux-next 23/25] drivers/acpi/ec.c:1936:12: error: redefinition of 'acpi_ec_suspend_noirq' kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201802080051.FW6lumI7%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=devel@acpica.org \
    --cc=kbuild-all@01.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).