* [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr
@ 2018-02-09 18:08 Gustavo A. R. Silva
2018-02-14 9:27 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-02-09 18:08 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-acpi, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1465078
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
This code was compiled with GCC 7.3.0
drivers/acpi/spcr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 89e97d2..9d52743 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
table->serial_port.access_width))) {
default:
pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n");
+ /* fall through */
case 8:
iotype = "mmio";
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr
2018-02-09 18:08 [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr Gustavo A. R. Silva
@ 2018-02-14 9:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2018-02-14 9:27 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Len Brown, linux-acpi, linux-kernel, Gustavo A. R. Silva
On Friday, February 9, 2018 7:08:21 PM CET Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1465078
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> This code was compiled with GCC 7.3.0
>
> drivers/acpi/spcr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index 89e97d2..9d52743 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> table->serial_port.access_width))) {
> default:
> pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n");
> + /* fall through */
> case 8:
> iotype = "mmio";
> break;
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-14 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 18:08 [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr Gustavo A. R. Silva
2018-02-14 9:27 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).