linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario.Limonciello@dell.com
Cc: rafael@kernel.org, lukas@wunner.de, alex.hung@canonical.com,
	andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com,
	jdelvare@suse.de, lenb@kernel.org, gregkh@linuxfoundation.org,
	davem@davemloft.net, f.fainelli@gmail.com, kishon@ti.com,
	karniksayli1995@gmail.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI / osi: add DMI quirk for Dell systems
Date: Tue, 13 Feb 2018 09:32:58 +0200	[thread overview]
Message-ID: <20180213073258.GX27191@lahna.fi.intel.com> (raw)
In-Reply-To: <81dad01f354e4dcab852d145ce5d9fb3@ausx13mpc120.AMER.DELL.COM>

On Mon, Feb 12, 2018 at 11:14:42PM +0000, Mario.Limonciello@dell.com wrote:
> > So something like "Do you support native PCI power management?" would
> > be fine, because native PCI power management is defined by the PCI
> > standard and it should be clear what supporting it means and it
> > doesn't depend on what platform the kernel runs on.
> > 
> 
> The problem is this is in conflict with the documentation.
> As quoted:
> 
> ```
> _OSI("Linux-OEM-my_interface_name")
> where 'OEM' is needed if this is an OEM-specific hook,
> and 'my_interface_name' describes the hook, which could be a
> quirk, a bug, or a bug-fix.
> ```
> 
> Quite literally from an OEM perspective this is a quirk.  The affected
> platforms as configured by default won't work properly with Linux.
> 
> We apply a code deviation if the OSPM responds yes to that OSI string.
> 
> It's entirely possible that the Linux kernel could not store a quirk table
> to match the affected platforms and instead give a blanket simple fast 
> "Yes" answer to "Linux-Dell-Video", but I think that is no better than
> _OSI("Linux").  This is at least an attestation from the OEM perspective
> that we have only changed one thing by this string.
> 
> The alternative (and what has been done in the past) was the ACPI
> _OSI rev hack marking those platforms for quirks and other things
> before that and.  I really don't want to go down that road again.

I have not followed this thread too closely so I might be missing
something but why do we need to do this in the first place? Does this
work in Windows and if yes, why we can't do the the same in Linux
without any sort of hacks and/or quirks?

  parent reply	other threads:[~2018-02-13  7:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  8:40 [PATCH 1/2] firmware: dmi_scan: add DMI_OEM_STRING support to dmi_matches Alex Hung
2018-01-31  8:40 ` [PATCH 2/2] ACPI / osi: add DMI quirk for Dell systems Alex Hung
2018-02-05 13:14   ` Jean Delvare
2018-02-05 14:15     ` Andy Shevchenko
2018-02-05 17:36       ` Mario.Limonciello
2018-02-05 22:45         ` Dmitry Torokhov
2018-02-06  0:45           ` Mario.Limonciello
2018-02-06 13:45             ` Andy Shevchenko
2018-02-06 16:24               ` Mario.Limonciello
2018-02-07 20:38                 ` Alex Hung
2018-02-07 20:49                   ` Mario.Limonciello
2018-02-11  9:29               ` Rafael J. Wysocki
2018-02-11 13:45                 ` Lukas Wunner
2018-02-12  9:49                   ` Rafael J. Wysocki
2018-02-12 20:29                     ` Mario.Limonciello
2018-02-12 22:57                       ` Rafael J. Wysocki
2018-02-12 23:14                         ` Mario.Limonciello
2018-02-13  5:25                           ` Alex Hung
2018-02-13  7:32                           ` Mika Westerberg [this message]
2018-02-14  9:06                             ` Rafael J. Wysocki
2018-02-14  9:50                               ` Mika Westerberg
2018-02-13  9:18                           ` Rafael J. Wysocki
2018-02-13  9:55                             ` Lukas Wunner
2018-02-14  9:10                               ` Rafael J. Wysocki
2018-02-14 18:47                             ` Mario.Limonciello
2018-02-15  9:44                               ` Rafael J. Wysocki
2018-02-05 17:24     ` Mario.Limonciello
2018-02-05 21:55       ` Jean Delvare
2018-02-07 20:05     ` Alex Hung
2018-02-05 10:26 ` [PATCH 1/2] firmware: dmi_scan: add DMI_OEM_STRING support to dmi_matches Jean Delvare
2018-02-07  5:25   ` Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213073258.GX27191@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=alex.hung@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdelvare@suse.de \
    --cc=karniksayli1995@gmail.com \
    --cc=kishon@ti.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).