From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 0/5] Teach EDAC about non-volatile DIMMs and add partial support to skx_edac Date: Wed, 28 Feb 2018 14:04:10 +0100 Message-ID: <20180228130410.GC3769@pd.tnic> References: <20180222195811.27237-1-tony.luck@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180222195811.27237-1-tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Tony Luck , Dan Williams , Jean Delvare Cc: Qiuxu Zhuo , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Aristeu Rozanski , "Rafael J. Wysocki" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lv Zheng , Mauro Carvalho Chehab , Len Brown List-Id: linux-acpi@vger.kernel.org On Thu, Feb 22, 2018 at 11:58:06AM -0800, Tony Luck wrote: > This series was posted as RFC and got some review back in December: > > https://marc.info/?l=linux-edac&m=151257213825419&w=2 > > It couldn't go upstream back then because I was waiting for some updates > to the ACPICA headers for NFIT support. Those patches are complete now, > so here is the series again. > > The "partial support" part is that the changes here only do the detection of > the non-volatile DIMMs. Coming later will be another patch/series to teach > skx_edac how to decode system addresses to NVDIMM addresses. But this part > stands on its own and is a useful first step. > > Tony Luck (5): > EDAC: Drop duplicated array of strings for memory type names > edac: Add new memory type for non-volatile DIMMs > acpi, nfit: Add function to look up nvdimm device and provide SMBIOS > handle > firmware: dmi: Add function to look up a handle and return DIMM size > EDAC, skx_edac: Detect non-volatile DIMMs > > drivers/acpi/nfit/core.c | 27 ++++++++++++++++++ > drivers/edac/Kconfig | 5 +++- > drivers/edac/edac_mc.c | 41 +++++++++++++------------- > drivers/edac/edac_mc_sysfs.c | 26 ++--------------- > drivers/edac/skx_edac.c | 68 ++++++++++++++++++++++++++++++++++++++++---- > drivers/firmware/dmi_scan.c | 31 ++++++++++++++++++++ > include/acpi/nfit.h | 26 +++++++++++++++++ > include/linux/dmi.h | 2 ++ > include/linux/edac.h | 3 ++ > 9 files changed, 178 insertions(+), 51 deletions(-) > create mode 100644 include/acpi/nfit.h Series looks ok to me. Dan, I could route patch 3 through the EDAC tree if you'd prefer. Jean, ditto for patch 4. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.