From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 5/5] EDAC, skx_edac: Detect non-volatile DIMMs Date: Tue, 13 Mar 2018 17:16:06 +0100 Message-ID: <20180313171606.4fef3ab6@endymion> References: <20180312182430.10335-1-tony.luck@intel.com> <20180312182430.10335-6-tony.luck@intel.com> <20180313105901.0f18d027@endymion> <20180313155956.zapcx3l5bb72w4yz@agluck-desk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180313155956.zapcx3l5bb72w4yz@agluck-desk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "Luck, Tony" Cc: Mauro Carvalho Chehab , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, "Rafael J. Wysocki" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Qiuxu Zhuo , Borislav Petkov , Aristeu Rozanski , Borislav Petkov , Len Brown List-Id: linux-acpi@vger.kernel.org On Tue, 13 Mar 2018 08:59:56 -0700, Luck, Tony wrote: > On Tue, Mar 13, 2018 at 10:59:01AM +0100, Jean Delvare wrote: > > > + edac_dbg(0, "mc#%d: channel %d, dimm %d, %llu Mb (%u pages)\n", > > > > I did not notice on previous review, but I think "b" in general means > > bit not byte, so "MB" would be better. > > Heh! We've been cut & pasting that line from EDAC drivers since the i7core_edac.c > I think the origin is in 2.6.35. So you are far from the only person to not > notice it in a review :-) Hehe :-D Then I guess a patch fixing all drivers are once is in order, after your patch set it accepted. > > > + imc->mc, chan, dimmno, size >> 20, dimm->nr_pages); > > > + > > > + snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", > > > + imc->src_id, imc->lmc, chan, dimmno); > > > + > > > + return 1; > > > +} > > > > Now this function always return 1, that doesn't make a lot of sense? > > I could fix the return to be: > > > diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c > index 84c18bb1e0cd..1a66e145c0bd 100644 > --- a/drivers/edac/skx_edac.c > +++ b/drivers/edac/skx_edac.c > @@ -429,7 +429,7 @@ static int get_nvdimm_info(struct dimm_info *dimm, struct skx_imc *imc, > snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", > imc->src_id, imc->lmc, chan, dimmno); > > - return 1; > + return (size == 0 || size == ~0ull) ? 0 : 1; > } Yes, I think it makes sense, thanks. -- Jean Delvare SUSE L3 Support