From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH] arm64: fix ACPI dependencies Date: Tue, 24 Jul 2018 10:49:59 +0100 Message-ID: <20180724094959.GH19324@arm.com> References: <20180724093345.1575921-1-arnd@arndb.de> <20180724094406.GF19324@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Catalin Marinas , "Rafael J. Wysocki" , Len Brown , AKASHI Takahiro , Ard Biesheuvel , Mark Rutland , Marc Zyngier , Linux ARM , Linux Kernel Mailing List , ACPI Devel Maling List List-Id: linux-acpi@vger.kernel.org On Tue, Jul 24, 2018 at 11:46:23AM +0200, Arnd Bergmann wrote: > On Tue, Jul 24, 2018 at 11:44 AM, Will Deacon wrote: > > On Tue, Jul 24, 2018 at 11:37:10AM +0200, Rafael J. Wysocki wrote: > >> On Tue, Jul 24, 2018 at 11:33 AM, Arnd Bergmann wrote: > > > > > How about something along the lines of what Ard suggested? Untested diff > > below. > > > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 303809c6..ec78d4d 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -56,6 +56,7 @@ config ARM64 > > select ARCH_USE_CMPXCHG_LOCKREF > > select ARCH_USE_QUEUED_RWLOCKS > > select ARCH_USE_QUEUED_SPINLOCKS > > + select ARCH_SUPPORTS_ACPI > > select ARCH_SUPPORTS_MEMORY_FAILURE > > select ARCH_SUPPORTS_ATOMIC_RMW > > select ARCH_SUPPORTS_INT128 if GCC_VERSION >= 50000 || CC_IS_CLANG > > I'd prefer Rafael's suggestion of just leaving out the architecture names from > the dependency, and making all three 'select ARCH_SUPPORTS_ACPI'. > > I'll send a v2. Ok, thanks. Will